Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inner mutexes to ChannelMonitor #805

Closed
TheBlueMatt opened this issue Feb 25, 2021 · 0 comments · Fixed by #813
Closed

Add inner mutexes to ChannelMonitor #805

TheBlueMatt opened this issue Feb 25, 2021 · 0 comments · Fixed by #813
Assignees
@jkczyz
Milestone
0.0.13

Comments

@TheBlueMatt
Copy link
Collaborator

Post-#791, we impl chain::Listen for RefCell<ChannelMonitor..>, which is both awkward and very inconsistent with all our other APIs. Instead, we should probably migrate to putting mutexes inside ChannelMonitor, which has a nice side benefit of being able to parallelize ChainMonitor::update_channel - if we move the HashMap into an RwLock we can take a read() lock there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkczyz jkczyz

Labels
None yet
Projects
None yet
Milestone
0.0.13
Development

Successfully merging a pull request may close this issue.

Use interior mutability in ChannelMonitor jkczyz/rust-lightning
2 participants
@TheBlueMatt @jkczyz