Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Re-build v0.3.1 release binaries from the correct staging commit #680

Closed
ffranr opened this issue Nov 16, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ffranr
Copy link
Contributor

ffranr commented Nov 16, 2023

The currently uploaded tag tag v0.3.1 release binaries were built using the wrong staging commit: cdd6707702788cccfe615be3b06fe34a96ce31c6. Tag v0.3.1 is at commit fec4a4025db21d2e47994ad4bff29aa5d31d02e9.

We should replace the release binaries found here with those built using the correct tag v0.3.1 staging commit.

Here's a link to new tag v0.3.1 release binaries that I've built from tag v0.3.1 at the correct commit fec4a:
https://drive.google.com/file/d/1Fhvie1FFXqYw6BCTXRRj8-3JbKiaC1nW/view?usp=sharing

The steps I used to create these new binaries:

  1. Clone repo into a new directory.
  2. Checkout tag v0.3.1
  3. Run make docker-release tag=v0.3.1

The differences in the binaries will be very slight. The correct commit is one ahead of the commit that was used to build the current binaries.

Completing this issue will help users verify the release binaries because they will be able to rebuild those binaries from the commit associated with tag v0.3.1.

FYI, this issue was initially reported here.

@ffranr ffranr added the bug Something isn't working label Nov 16, 2023
@ffranr ffranr self-assigned this Nov 16, 2023
@ffranr ffranr moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Nov 16, 2023
@ffranr
Copy link
Contributor Author

ffranr commented Nov 16, 2023

I think @jharveyb confirmed that he derived the same manifest hashes here: #661 (comment)

Is that still true? And if so then I'll upload these new binaries and someone else can check my work. Agreed?

@ffranr
Copy link
Contributor Author

ffranr commented Nov 20, 2023

I've just uploaded the correct assets for release v0.3.1.

@ffranr ffranr closed this as completed Nov 20, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant