[bug]: clean up Python gRPC client instructions #9285
Labels
beginner
Issues suitable for new developers
documentation
Documentation changes that do not affect code behaviour
good first issue
Issues suitable for first time contributors to LND
needs triage
There are some things in the Python gRPC client instructions that were never needed or are no longer needed.
On lines
lnd/docs/grpc/python.md
Lines 20 to 24 in e6efa2e
grpcio googleapis-common-protos mypy-protobuf
can be removed.
grpcio
is automatically installed bygrpcio-tools
andgoogleapis-common-protos
is not actually needed becausegoogle/api/annotations.proto
is not actually needed by the Python gRPC client. As mentioned below,--mypy_out=.
does not seem to be actually needed, so that removes the need formypy-protobuf
.Lines
lnd/docs/grpc/python.md
Lines 25 to 29 in e6efa2e
can be deleted.
On lines
lnd/docs/grpc/python.md
Line 38 in e1df8e9
and
lnd/docs/grpc/python.md
Line 56 in e1df8e9
--proto_path=googleapis:.
can be replaced with--proto_path=.
.
I'm also not sure what
--mypy_out=.
is for on lineslnd/docs/grpc/python.md
Line 38 in e1df8e9
and
lnd/docs/grpc/python.md
Line 56 in e1df8e9
It also does not seem to be needed
Also, I'm not a Ruby user, but I'm guessing references to
googleapis
inhttps://github.com/lightningnetwork/lnd/blob/master/docs/grpc/ruby.md
can probably be removed as well.
The text was updated successfully, but these errors were encountered: