Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add grace period to SEP-10 challenge parsing function #358

Closed
JakeUrban opened this issue Sep 16, 2021 · 1 comment · Fixed by #366
Closed

Feature Request: Add grace period to SEP-10 challenge parsing function #358

JakeUrban opened this issue Sep 16, 2021 · 1 comment · Fixed by #366
Labels

Comments

@JakeUrban
Copy link
Contributor

What problem does your feature solve?

Its possible for the SEP-10 challenge's minTime constraint to be "in the future" for the client application parsing the challenge due to clock drift.

What would you like to see?

We've implemented a grace period for the min time constraint in the Go SDK, and both the min and max time in the JS SDK. I'd like us to do the same here.

What alternatives are there?

N/A

@JakeUrban JakeUrban added the bug label Sep 16, 2021
@salimwyre
Copy link

👍 When using the SDK as a client and the test anchor as a server we hit that case "minTime in the future" about 5% of the time
Timing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants