Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAS-1854] 🎨 Set nftName as the filename #7

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

AuroraHuang22
Copy link
Collaborator

data.name = nftName from liker.land

The open() in the webViewerPostMessage, assign the _contentDispositionFilename, which will serve as the preferred download filename.

@AuroraHuang22 AuroraHuang22 changed the title 🎨 Set nftName as the filename [TAS-1854] 🎨 Set nftName as the filename Jul 12, 2024
Copy link

@williamchong williamchong self-requested a review July 12, 2024 08:47
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to guard cases when data.name is undefined

@williamchong williamchong merged commit 61162d6 into likecoin:master Jul 12, 2024
6 of 7 checks passed
williamchong pushed a commit that referenced this pull request Oct 3, 2024
* 🎨 Set nftName as the filename

* 🥅 Guard data name undefined
williamchong pushed a commit that referenced this pull request Dec 16, 2024
* 🎨 Set nftName as the filename

* 🥅 Guard data name undefined
williamchong pushed a commit that referenced this pull request Dec 16, 2024
* 🎨 Set nftName as the filename

* 🥅 Guard data name undefined
williamchong pushed a commit that referenced this pull request Feb 3, 2025
* 🎨 Set nftName as the filename

* 🥅 Guard data name undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants