Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Set filename outside of PDFJSDev environment check #8

Merged
merged 1 commit into from
Jul 29, 2024
Merged

🎨 Set filename outside of PDFJSDev environment check #8

merged 1 commit into from
Jul 29, 2024

Conversation

AuroraHuang22
Copy link
Collaborator

@AuroraHuang22 AuroraHuang22 commented Jul 15, 2024 •
edited
Loading

Keep URL to trigger setting this.url

this.url = arg.originalUrl || arg.url
_docFilename = this._contentDispositionFilename || getPdfFilenameFromUrl(this.url);

williamchong
williamchong approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be even better if the url is actually meaningful in some way

@nwingt nwingt merged commit 975f17f into likecoin:master Jul 29, 2024
6 of 7 checks passed
williamchong pushed a commit that referenced this pull request Oct 3, 2024
@AuroraHuang22 @williamchong
🎨 Set default url for webViewerPostMessage (#8)
d6a398c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamchong williamchong williamchong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AuroraHuang22 @williamchong @nwingt