Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml's target-version doesn't respect python version answers #378

Closed
hombit opened this issue Feb 4, 2024 · 0 comments · Fixed by #386
Closed

pyproject.toml's target-version doesn't respect python version answers #378

hombit opened this issue Feb 4, 2024 · 0 comments · Fixed by #386
Milestone
Release tag 2.0

Comments

@hombit
Copy link
Contributor

hombit commented Feb 4, 2024 •
edited
Loading

In the current main branch, pyproject.toml has target-version specified in multiple places including [tool.black] and [tool.ruff]. This item is currently hard-coded to 3.8. It should be, instead, set to the minimum of the python versions selected by user.
@drewoldag drewoldag linked a pull request Feb 6, 2024 that will close this issue
Use lowest available python version #386
Merged
3 tasks
@delucchi-cmu delucchi-cmu added this to the Release tag 2.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release tag 2.0
Development

Successfully merging a pull request may close this issue.

Use lowest available python version lincc-frameworks/python-project-template
2 participants
@hombit @delucchi-cmu