Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JpqlSerializer for JpqlNullIf #347

Closed
shouwn opened this issue Jul 19, 2023 · 5 comments
Closed

Implement JpqlSerializer for JpqlNullIf #347

shouwn opened this issue Jul 19, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@shouwn
Copy link
Member

shouwn commented Jul 19, 2023

Backgrounds

  • In Kotlin JDSL 3.0.0, the Query objects no longer know how to draw themselves as SQL String.
  • The Query object is drawn in JPQL String by JpqlSerializer.

Requirements

  • Please implement JpqlSerializer that draws JpqlNullIf as a SQL String.
  • Please implement a unit test for the implemented class.

Contribution

  • Please check if there is an assignee in this issue. And if it don't have an assignee, please change the assignee to yourself.
  • Please check the commit convention through the commitlint.config.js file. The commit convention also described in the PR template.
  • When you use intellij, please set the code style through the .editorconfig file.
  • Please create the PR for develop/3.0.0 as the base branch.
  • If you have any questions, please leave comment in Kotlin-JDSL Discord Channel in LINE Open Source
@shouwn shouwn added good first issue Good for newcomers enhancement New feature or request labels Jul 19, 2023
@shouwn shouwn added this to the 3.0.0 milestone Jul 19, 2023
@waveofmymind
Copy link
Contributor

안녕하세요!
assign 부탁드립니다 :)

@shouwn
Copy link
Member Author

shouwn commented Aug 14, 2023

Hi @waveofmymind

I haven't checked my mail properly yesterday and today. The email history shows that you requested to assign the ticket, but I don't see them in the current thread. Did you remove your comments because I didn't respond?

If so, this is my fault. If you'd like to contribute, please comment again.

@waveofmymind
Copy link
Contributor

@shouwn
Yes. I requested to be assigned the ticket for JpqlPlus, but since I'm still not familiar with contributing, I intend to first tackle the JpqlNullIf that I've already been assigned.
Once this issue is resolved, I will leave a comment again in the future!
Thank you for your attention.

@shouwn
Copy link
Member Author

shouwn commented Aug 14, 2023

Oh, I see. Thank you for your contribution!

@shouwn
Copy link
Member Author

shouwn commented Aug 15, 2023

This issue is closed by #405

@shouwn shouwn closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants