Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump line/lbm-sdk to a7557b1d10 #8

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Bump line/lbm-sdk to a7557b1d10 #8

merged 2 commits into from
Feb 9, 2023

Conversation

0Tech
Copy link

@0Tech 0Tech commented Feb 9, 2023

Description

  • a7557b1d10: bankplus.NewBaseKeeper() wants one more argument which decides whether or not to disable /cosmos.bank.v1beta1.MsgMultiSend.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech requested a review from zemyblue February 9, 2023 07:38
@0Tech 0Tech self-assigned this Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #8 (f84f92c) into main (60fec8a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   60.80%   60.81%           
=======================================
  Files          80       80           
  Lines        9877     9879    +2     
=======================================
+ Hits         6006     6008    +2     
  Misses       3555     3555           
  Partials      316      316           
Impacted Files Coverage Δ
app/app.go 88.01% <100.00%> (+0.02%) ⬆️
appplus/app.go 88.82% <100.00%> (+0.02%) ⬆️

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the more description why does this bump up need, or what is the main changes.

@0Tech 0Tech requested a review from zemyblue February 9, 2023 07:57
@0Tech 0Tech merged commit e0d9c95 into Finschia:main Feb 9, 2023
@0Tech 0Tech deleted the bumpup branch February 9, 2023 08:15
@zemyblue zemyblue mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants