Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of automatic focus in LifeCycle events #2318

Closed
sprocklem opened this issue Dec 30, 2022 · 2 comments · Fixed by #2320
Closed

Fix documentation of automatic focus in LifeCycle events #2318

sprocklem opened this issue Dec 30, 2022 · 2 comments · Fixed by #2320

Comments

@sprocklem
Copy link
Contributor

Currently, the documentation tells users to to call LifeCycleCtx::register_for_focus() in the documentation for both LifeCycle::WidgetAdded (as in version 0.7) and the new LifeCycle::BuildFocusChain. I believe that the relevant section in the former simply needs to be deleted.

I can submit a pull request for this when I have time later today, if need be.
@sprocklem
Copy link
Contributor Author

Also, there is a spelling error in the latter ("witch" should be "which").

@xStrom
Copy link
Member

xStrom commented Dec 31, 2022

There are some doc changes in #2301, but at a quick glance doesn't look like it addresses this. Might be worth taking a look at that to confirm.

If you think the docs are wrong then a pull request would definitely be welcome.

@sprocklem sprocklem mentioned this issue Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated documentation in LifeCycle events sprocklem/druid
2 participants
@xStrom @sprocklem