Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "fast" autolock. #235

Closed
bleykauf opened this issue Jan 19, 2022 · 4 comments · Fixed by #346
Closed

Rename "fast" autolock. #235

bleykauf opened this issue Jan 19, 2022 · 4 comments · Fixed by #346
Labels
enhancement Improvement to existing feature idea Just an idea

Comments

@bleykauf
Copy link
Collaborator

I think "fast" autolock is not a really good description for end users since they won't most probably not notice a different in the time it takes for the lock to engage. Also, there are "fast" in and outputs: would be better not to reuse the name.

I think "simple" would be a better description. Any other ideas, @hermitdemschoenenleben ?

@bleykauf bleykauf added enhancement Improvement to existing feature idea Just an idea labels Jan 19, 2022
@bleykauf
Copy link
Collaborator Author

Or "FPGA" and "CPU" as it is indicated in the tests?

@hermitdemschoenenleben
Copy link
Collaborator

late-responding to the ping :D in the paper we used "Jitter tolerant autolock". Might be a good choice for the UI as well as a user doesn't care about the implementation details but wants to know what it does / why they should use it

@bleykauf
Copy link
Collaborator Author

@hermitdemschoenenleben: the jitter-tolerant is already called like this. It is slow since several spectra are recorded. It's the other mode that is called "fast mode". I guess "simple mode" is probably a better name. And then there is "fast mode" which is PID only as well..

@bleykauf
Copy link
Collaborator Author

bleykauf commented Dec 5, 2023

Closed via #363.

@bleykauf bleykauf closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature idea Just an idea
Projects
None yet
2 participants