Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurations page is not updated #1872

Closed
mohitpali opened this issue Jul 28, 2022 · 7 comments
Closed

Configurations page is not updated #1872

mohitpali opened this issue Jul 28, 2022 · 7 comments
Labels
productivity A meta-change in the project.

Comments

@mohitpali
Copy link
Contributor

I had made changes to configurations wiki in #1809. However, the configurations page is not reflecting the changes - https://github.com/linkedin/cruise-control/wiki/Configurations.

Am i missing something ?

@wyuka
Copy link

wyuka commented Aug 4, 2022

We need to keep the wiki in sync - https://gist.github.com/subfuzion/0d3f19c4f780a7d75ba2

We can probably set up a github action to do it.

@wyuka wyuka added usability Improves the ease of use or learnability of the system. productivity A meta-change in the project. and removed usability Improves the ease of use or learnability of the system. labels Aug 4, 2022
@mohitpali
Copy link
Contributor Author

@CCisGG I have updated the wiki at my fork - https://github.com/mohitpali/cruise-control/wiki

Since there does not seem to be a way to create a way to create a PR for wiki, could you please pull my changes from my forked wiki ?

https://stackoverflow.com/questions/10642928/how-can-i-make-a-pull-request-for-a-wiki-page-on-github

@CCisGG
Copy link
Contributor

CCisGG commented Jan 12, 2023

Hi @mohitpali I pulled your changes locally and looks like there are multiple changes. Could you explain why you were making those changes?

E.g. looks like you:

  • removed a lot of zk configurations
  • change zk connect to false (I assume those are because cc is moving away from zk)
  • removed broker failure detection config

@mohitpali
Copy link
Contributor Author

@CCisGG did you pull the wiki repo only ?

@CCisGG
Copy link
Contributor

CCisGG commented Jan 13, 2023

Hi @mohitpali I pulled your migrate_to_2_4 branch and checkout to the "wiki" repo. Let me know if I misunderstood something here.

@mohitpali
Copy link
Contributor Author

Wiki has its own branch and there is only master branch. The url should be <>.wiki.git

@CCisGG
Copy link
Contributor

CCisGG commented Jan 18, 2023

Wiki updated.

@CCisGG CCisGG closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
productivity A meta-change in the project.
Projects
None yet
Development

No branches or pull requests

3 participants