Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach a model name to the serialized GAME model #127

Open
XianXing opened this issue Jun 28, 2016 · 1 comment
Open

Attach a model name to the serialized GAME model #127

XianXing opened this issue Jun 28, 2016 · 1 comment

Comments

@XianXing
Copy link
Contributor

The Ads team made a suggestion to us, that we may want to add something like a model name to the serialized GAME model, which might be helpful if multiple GAME models are trained offline and served online at the same time.

I guess one thing we can do is to add a field called modelName to each Avro record in addition to the field modelClass we added recently in PR #123.

However, we may need to disambiguate the existing modelId field and the to-be-added modelName field, or we need better names for both of them. For example, rename modelId to effectId, because essentially what modelId current does is to store the fixed/random effect id associated with that particular fixed/random effect model, like the user id (if it's a per-user random effect model) or the item id (if it's a per-item random effect model).

@fastier-li fastier-li self-assigned this Mar 16, 2017
@fastier-li
Copy link
Member

I wrote a model format converter for another LI system recently and included a model name in the output file. I'll see how to "finish that up" by surfacing the name more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants