Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry for Upgrades and CONNECT #1206

Open
seanmonstar opened this issue Jun 26, 2018 · 2 comments
Open

Telemetry for Upgrades and CONNECT #1206

seanmonstar opened this issue Jun 26, 2018 · 2 comments

Comments

@seanmonstar
Copy link
Contributor

We now support both HTTP Upgrades (#1126) and CONNECT (#1200). They both make use of the HTTP sensors while the requests look like HTTP/1, and once the upgrade is complete, they convert into TCP proxies. That means no more HTTP sensors are used, but the transport sensors are still in place.

However, these are both probably significant enough to warrant emitting special events in our telemetry, so that users can see successful (and failed) HTTP Upgrades / CONNECT. Or maybe just Upgrades are sufficiently important.

A related question is whether something should be exposed in TAP.

@stale
Copy link

stale bot commented Oct 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 10, 2018
@klingerf klingerf added the rfc label Oct 10, 2018
@stale stale bot removed the wontfix label Oct 10, 2018
@grampelberg
Copy link
Contributor

@olix0r are we publishing metrics for these today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants