Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme steps 2 & 3 elaboration #14

Closed
turbomam opened this issue Sep 20, 2022 · 5 comments
Closed

readme steps 2 & 3 elaboration #14

turbomam opened this issue Sep 20, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@turbomam
Copy link

turbomam commented Sep 20, 2022

Users don't need to reinstall poetry if they already have it

poetry --version

See also https://python-poetry.org/history/

poetry self update if desired

What should the response to the poetry init questions be?

@turbomam
Copy link
Author

turbomam commented Sep 20, 2022

are you sure that poetry install is required after adding the older version of click?

poetry install

Installing dependencies from lock file

No dependencies to install or update

@turbomam
Copy link
Author

Any reason the two-line step 3 shouldn't be

poetry run cruft create https://github.com/linkml/linkml-project-cookiecutter

@turbomam turbomam changed the title readme step 2 elaboration readme steps 2 & 3 elaboration Sep 20, 2022
@turbomam
Copy link
Author

What is the google_analytics_gtag for?

@turbomam
Copy link
Author

Clarify in the readme or the cruft script:

github_token_for_pypi_deployment [PYPI_PASSWORD]

just defines the name of the GH secret that our actions will be looking for

@nlharris nlharris added the documentation Improvements or additions to documentation label Oct 27, 2022
@pkalita-lbl
Copy link
Contributor

This appears to be based on the instructions prior to #84.

google_analytics_gtag was removed from the setup questions in #24

I believe github_token_for_pypi_deployment is now sufficiently explained in the README.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants