Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin six at version with PY2 property #81

Conversation

pipermerriam
Copy link
Contributor

What was wrong?

The six library was added as a dependency when python3 support was added. One of the features used is the boolean six.PY2. Currently, the six dependency does not declare a version.

The six.PY2 property was not introduced until six==1.4.0.

If someone has an older version of six installed, then the dependency will be met, but an error will occur with python-memcached tries to access this property.

how was it fixed.

Pinned the six dependency as six>=1.4.0 which will ensure that a compatible six version is installed.

Cute animal picture.

tumblr_inline_n2cqllmpgp1ryxil9

@pipermerriam
Copy link
Contributor Author

If the maintainers of this project don't want to pin to a version of six, then I can redo this so that it checks for the property and if it isn't present, does the equivalent check inline.

if getattr(six, "PY2", sys.version_info[0] == 2):
    ...

@linsomniac linsomniac merged commit 6b2edeb into linsomniac:master May 27, 2016
@linsomniac
Copy link
Owner

Looks good, thanks for the contribution.

@pipermerriam pipermerriam deleted the piper/pin-six-at-version-with-PY2-property branch May 27, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants