Pin six at version with PY2 property #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
six
library was added as a dependency when python3 support was added. One of the features used is the booleansix.PY2
. Currently, thesix
dependency does not declare a version.The
six.PY2
property was not introduced untilsix==1.4.0
.If someone has an older version of
six
installed, then the dependency will be met, but an error will occur withpython-memcached
tries to access this property.how was it fixed.
Pinned the
six
dependency assix>=1.4.0
which will ensure that a compatible six version is installed.Cute animal picture.