Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck to CI #12

Merged
merged 2 commits into from
Aug 21, 2020
Merged

add shellcheck to CI #12

merged 2 commits into from
Aug 21, 2020

Conversation

richm
Copy link
Contributor

@richm richm commented May 6, 2020 •
edited
Loading

Add shellcheck to check shell scripts in CI. Fix shellcheck issues found by initial run.

@richm richm force-pushed the shellcheck-fix-automated-mode branch from 0c79fde to 3c18f7f Compare May 8, 2020 14:46
@richm richm changed the title shellcheck add shellcheck to CI May 8, 2020
@richm richm requested review from i386x, pcahyna and tyll May 8, 2020 15:16
@richm
Copy link
Contributor Author

richm commented May 8, 2020

@robled

tyll
tyll reviewed May 8, 2020
View reviewed changes
i386x
i386x approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@i386x i386x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pcahyna
Copy link
Member

pcahyna commented May 11, 2020

This does not run shellcheck on the roles, just on the auto_maintenance repository itself, right?

@richm
Copy link
Contributor Author

richm commented May 11, 2020

This does not run shellcheck on the roles, just on the auto_maintenance repository itself, right?

correct - we will need to create a tox test in template, then sync it to the roles

richm added 2 commits August 3, 2020 16:16
@richm
use shellcheck for CI for shell scripts
d71ca84 
shellcheck is used check shell scripts for many common errors.
shellcheck is built-in to Travis CI
This commit enables Travis CI shellcheck for shell scripts
@richm
address shellcheck issues in our shell scripts
97ec2df
@richm richm force-pushed the shellcheck-fix-automated-mode branch from d999ca3 to 97ec2df Compare August 3, 2020 22:18
@richm
Copy link
Contributor Author

richm commented Aug 3, 2020

This does not run shellcheck on the roles, just on the auto_maintenance repository itself, right?

correct - we will need to create a tox test in template, then sync it to the roles

shellcheck has been added to the template. Before making the changes to sync-template.sh to allow it to sync those changes to the roles, I would like to merge this PR. @tyll had some concerns - I think they have been addressed, and I refactored this PR as suggested by @tyll in another PR to have the first commit to add shellcheck to the CI, and a subsequent commit to address the issues found by shellcheck.

@richm
Copy link
Contributor Author

richm commented Aug 6, 2020

ok to merge?

2 similar comments
@richm
Copy link
Contributor Author

richm commented Aug 10, 2020

ok to merge?

@richm
Copy link
Contributor Author

richm commented Aug 20, 2020

ok to merge?

@tyll
Copy link
Member

tyll commented Aug 21, 2020

works for me

@richm richm merged commit dacc8fb into linux-system-roles:master Aug 21, 2020
@richm richm deleted the shellcheck-fix-automated-mode branch August 21, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyll tyll tyll left review comments

@i386x i386x i386x approved these changes

@pcahyna pcahyna Awaiting requested review from pcahyna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richm @pcahyna @tyll @i386x