Fix the update-collections script - bump release in spec and build vendored_collections.yml correctly #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrosi
force-pushed
the
update-vendored-fix-release
branch
3 times, most recently
from
50df2e9 to
3e2162d
Compare
The script removed it in e26e356 and that's incorrect
spetrosi
force-pushed
the
update-vendored-fix-release
branch
from
3e2162d to
67f4cf6
Compare
richm
reviewed
Apr 4, 2022
richm
reviewed
Apr 4, 2022
| content = re.sub( | ||
| r"^Release: \d+", "Release: " + new_release, content, flags=re.MULTILINE | ||
| ) | ||
| return content |
There was a problem hiding this comment.
You also need to update the release number in the changelog entry
There was a problem hiding this comment.
Script does this in spec_add_changelog: https://github.com/linux-system-roles/auto-maintenance/blob/master/update_vendored_collections/update_vendored_collections.py#L95
spetrosi
force-pushed
the
update-vendored-fix-release
branch
from
e65f8cc to
71bba05
Compare
spetrosi
force-pushed
the
update-vendored-fix-release
branch
from
71bba05 to
1baa7fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140