From 155ffafc661570f618fd67aed71497e84ceff8ef Mon Sep 17 00:00:00 2001
From: Rich Megginson <rmeggins@redhat.com>
Date: Tue, 29 Oct 2024 16:27:21 -0600
Subject: [PATCH] test: disable service start limit to avoid errors during
 testing

In some cases running the test gives errors like this:

```
Unable to restart service systemd-journal-flush.service:
Job for systemd-journal-flush.service failed because
start of the service was attempted too often
```

Set `StartLimitIntervalSec=0` to avoid this problem.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
---
 tests/tests_example.yml | 45 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/tests/tests_example.yml b/tests/tests_example.yml
index 9763dc3..edc4fe2 100644
--- a/tests/tests_example.yml
+++ b/tests/tests_example.yml
@@ -10,10 +10,45 @@
     journald_forward_to_syslog: true
     journald_rate_limit_burst: 2000
     journald_rate_limit_interval_sec: 2
+    __service_files:
+      - systemd-journald.service
+      - systemd-journal-flush.service
 
   tasks:
     - name: Run test
       block:
+        - name: Make a copy of the service files
+          copy:
+            src: /usr/lib/systemd/system/{{ item }}
+            dest: /etc/systemd/system/{{ item }}
+            remote_src: true
+            mode: preserve
+          loop: "{{ __service_files }}"
+
+        - name: Change the startlimit to avoid errors with excessive journald restarts
+          lineinfile:
+            path: /etc/systemd/system/{{ item }}
+            insertafter: ^\[Unit\]
+            line: StartLimitIntervalSec=0
+          loop: "{{ __service_files }}"
+
+        - name: Make a copy of the systemd-journald.service
+          copy:
+            src: /usr/lib/systemd/system/systemd-journald.service
+            dest: /etc/systemd/system/systemd-journald.service
+            remote_src: true
+            mode: preserve
+
+        - name: Change the startlimit to avoid errors with excessive journald restarts
+          lineinfile:
+            path: /etc/systemd/system/systemd-journald.service
+            insertafter: ^\[Unit\]
+            line: StartLimitIntervalSec=0
+
+        - name: Reload systemd to ensure startlimit changes take effect upon restart
+          systemd:
+            daemon_reload: true
+
         - name: Run the role
           include_role:
             name: linux-system-roles.journald
@@ -109,6 +144,16 @@
             path: "{{ __journald_dropin_dir }}/{{ __journald_dropin_conf }}"
             state: absent
 
+        - name: Remove copy of the service files
+          file:
+            path: /etc/systemd/system/{{ item }}
+            state: absent
+          loop: "{{ __service_files }}"
+
+        - name: Reload systemd to cleanup
+          systemd:
+            daemon_reload: true
+
         - name: Restart journald services
           service:
             name: "{{ item }}"