fix test tmp files #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richm
commented
Sep 23, 2022
richm
commented
- use no_log: true where secrets might be revealed
- tests - use generated temp directory for all controller files
- test support for CentOS Stream 9
|
[citest] |
richm
force-pushed
the
fix-test-tmp-files
branch
from
df4eb43 to
184645e
Compare
If you run multiple tests in parallel, some of the tests could overwrite or remove files in use by other tests on the controller. Use a temp directory for controller files.
richm
force-pushed
the
fix-test-tmp-files
branch
from
184645e to
f4f77c3
Compare
|
[citest] |
1 similar comment
|
[citest] |
|
[citest pending] |
1 similar comment
|
[citest pending] |
|
[citest] |
richm
added a commit
to richm/linux-system-roles-nbde_client
that referenced
this pull request
Nov 1, 2022
[1.2.7] - 2022-11-01 -------------------- ### New Features - none ### Bug Fixes - correct clevis askpass unit conditional (linux-system-roles#81) - Add default clevis luks askpass unit (linux-system-roles#79) skip clevis askpass systemd unit for RHEL 8.2 and 8.3 - use no_log: true where secrets might be revealed ### Other Changes - fix test tmp files (linux-system-roles#80) tests - use generated temp directory for all controller files If you run multiple tests in parallel, some of the tests could overwrite or remove files in use by other tests on the controller. Use a temp directory for controller files. - test support for CentOS Stream 9 Signed-off-by: Rich Megginson <[email protected]>
richm
added a commit
that referenced
this pull request
Nov 1, 2022
[1.2.7] - 2022-11-01 -------------------- ### New Features - none ### Bug Fixes - correct clevis askpass unit conditional (#81) - Add default clevis luks askpass unit (#79) skip clevis askpass systemd unit for RHEL 8.2 and 8.3 - use no_log: true where secrets might be revealed ### Other Changes - fix test tmp files (#80) tests - use generated temp directory for all controller files If you run multiple tests in parallel, some of the tests could overwrite or remove files in use by other tests on the controller. Use a temp directory for controller files. - test support for CentOS Stream 9 Signed-off-by: Rich Megginson <[email protected]> Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.