Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate non-inclusive language #546

Closed
nhosoi opened this issue Dec 21, 2022 · 5 comments
Closed

Eliminate non-inclusive language #546

nhosoi opened this issue Dec 21, 2022 · 5 comments
Assignees

Comments

@nhosoi
Copy link
Contributor

nhosoi commented Dec 21, 2022

Hello, we have a project to eliminate non-inclusive language from the linux-system-roles.

Running a utility woke (now it's supported in tox. please install the latest tox-lsr and run tox -e woke), two non-inclusive words are reported - dummy, whitelist, blacklist, master, and slave.

Can we replace them with more appropriate words? We are worried some of the words are coming from the network subsystems themselves that the network role depends upon. I'd think "eliminating non-inclusive language" is a common project among us including the subsystems. How are they solving the issue? If the network subsystems are already working on them, we could follow their effort.

Can we ask you to share the network team's policy on this matter with us? Thanks!

@nhosoi
Copy link
Contributor Author

nhosoi commented Dec 21, 2022

Output from tox -e woke

@liangwen12year liangwen12year self-assigned this Jan 9, 2023
@liangwen12year
Copy link
Collaborator

AFAIK, @ffmancera is working on the conscious language in NM side. For the non-inclusive language relied on the NM side, I will coordinate with Fernando to properly address this. Thanks for reporting the issue.

@richm
Copy link
Contributor

richm commented Jan 12, 2023

Looks like many of these issues will be solved by adding # wokeignore: rule=master comments e.g. https://github.com/linux-system-roles/network/blob/main/module_utils/network_lsr/ethtool.py#L26

https://github.com/linux-system-roles/network/blob/main/.mdl_style.rb#L2

etc.

Use of the word "dummy" appears in many names of test devices, variables, and some files. These will preferably be renamed. However, it does appear to be used as an NM keyword, so we'll have to add a wokeignore comment for those uses.

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 15, 2023

@liangwen12year, @richm, could you please take a look at this PR?
#551
Not sure why this test failed, though...
coverage/coveralls — Coverage decreased (-1.0%) to 42.421%

@nhosoi
Copy link
Contributor Author

nhosoi commented Jan 19, 2023

#551 is merged.
Thank you for reviewing and merging the pr.

@nhosoi nhosoi closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants