fix: correctly set release using new behavior of rhsm_release

[richm]

The way the new version of rhsm_release works is - if the release
parameter is present, set the release to the given value.
If there is no release parameter, unset the release.
If the user does not set rhc_release, then it will be null,
and calling the rhsm_release module will be skipped.
See ansible-collections/community.general#6401
for details.

Signed-off-by: Rich Megginson [email protected]

[ptoscano]

[citest]

[ptoscano]

It'd seem OK at a quick glance; i need to test this manually using tests_release.yml, as a self-deployed Candlepin has no concept of "releases".

[ptoscano]

Unfortunately this does not fix the situation completely, and unsetting a release (i.e. specifying rhc_release {"state":"absent"}) is still broken when using ansible-core 2.15:

argument 'release' is of type <class 'NoneType'> and we were unable to convert to str: 'None' is not a string and conversion is not allowed

this was tested using tests_release.yml using a real account to the internal Stage and a GA RHEL version (i.e. not a nightly/devel one, as those do not have the concept of "release").

The situation is the following:

• ansible-core 2.15 rejected null as valid parameter: argspec - fix validating type for required options that are None ansible/ansible#79677
• ... so rhsm_release was changed in community.general 6.6.0 to not require the release parameter, unsetting the release if not specified: rhsm_release: removing required=true for 'release' option ansible-collections/community.general#6401
• ... so we would adapt to that (and bump the requirement to community.general >= 6.6.0, however our version is pinned to < 6.5.0 for other reasons: Temporarily pin down community.general collection #86
• ... so we would unpin the requirement, however it is not possible yet as it would break Fedora managed nodes: chore(meta): stop pinning community.general collection #91
• fixing Fedora means fixing the SELinux policy: Allow rhsmcertd file transition in /run also for socket files fedora-selinux/selinux-policy#1726
• the above PR currently hits the temporary dnf.conf screwup in Rawhide: https://bugzilla.redhat.com/show_bug.cgi?id=2210694

Yes, a giant mess.

[ptoscano]

Yes, a giant mess.

Let's untangle it by temporarily dropping the support for Fedora: #109.

[ptoscano]

OK, created #110 so we can rely on a newer rhsm_release module from community.general.

Because of the new behaviour, we can simplify things a bit: instead of two rhsm_release invocations (depending on whether we need to set or unset a release), they can be merged into one, i.e. passing the "release" parameter when setting or omiting it when unsetting.

[richm]

[citest]

[ptoscano]

[citest]

[ptoscano]

Thanks! The release handling LGTM now, and tests_release nicely passes (tested with a Stage account, using a combo of (ansible-core-2.11, ansible-core-2.15) x (rhel-8-8, rhel-9-2)).

I will wait the successful CI run to merge this.