Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin Candlepin version to latest before Java 17 #85

Merged

Conversation

ptoscano
Copy link
Collaborator

@ptoscano ptoscano commented Apr 2, 2023

The current way of deploying Candlepin uses an Ansible role that is no more used/supported by the Candlepin project, and thus it is rotting; the recent switch of Candlepin from Java 11 to Java 17 broke with the unmaintained role.

Thus, as very short-term workaround, pin the version of Candlepin to deploy to the commit before the switch to Java 17.

The current way of deploying Candlepin uses an Ansible role that is no
more used/supported by the Candlepin project, and thus it is rotting;
the recent switch of Candlepin from Java 11 to Java 17 broke with the
unmaintained role.

Thus, as very short-term workaround, pin the version of Candlepin to
deploy to the commit before the switch to Java 17.

Signed-off-by: Pino Toscano <[email protected]>
@ptoscano ptoscano requested a review from richm as a code owner April 2, 2023 10:15
@ptoscano
Copy link
Collaborator Author

ptoscano commented Apr 2, 2023

[citest]

@ptoscano
Copy link
Collaborator Author

ptoscano commented Apr 3, 2023

OK, things generally work fine, at least from a Candlepin POV.

The issues that shows up are the same that appeared for #84 too, i.e.:

Since almost everything is external (either Fedora or the redhat_subscription module in the community.general collection), I'd get this in anyway for now (or at least wait for the Fedora errata), and hopefully at the end of the month we can get a new version of community.general with the fixes there.

@richm
Copy link
Contributor

richm commented Apr 3, 2023

OK, things generally work fine, at least from a Candlepin POV.

The issues that shows up are the same that appeared for #84 too, i.e.:

* old sub-man in Fedora:
  
  * F36 fix: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa252fd1a
  * F37 fix: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fff381197f

* wrong D-Bus option for environments in CentOS Stream 8:
  
  * fix in `redhat_subscription`: [redhat_subscription: fix D-Bus option for environments on CentOS ansible-collections/community.general#6275](https://github.com/ansible-collections/community.general/pull/6275)

Is this the issue that affects rhel 8.9 as well?

* wrong environment selection

Since almost everything is external (either Fedora or the redhat_subscription module in the community.general collection), I'd get this in anyway for now (or at least wait for the Fedora errata), and hopefully at the end of the month we can get a new version of community.general with the fixes there.

@ptoscano
Copy link
Collaborator Author

ptoscano commented Apr 3, 2023

Is this the issue that affects rhel 8.9 as well?

No, the above issue affects only CentOS Stream 8; the failure of RHEL 8.9 is the same for every OS, and it's...

  • wrong environment selection

... this.

@richm
Copy link
Contributor

richm commented Apr 3, 2023

Is this the issue that affects rhel 8.9 as well?

No, the above issue affects only CentOS Stream 8; the failure of RHEL 8.9 is the same for every OS, and it's...

  • wrong environment selection

... this.

Every OS except rhel 9.3?

@ptoscano
Copy link
Collaborator Author

ptoscano commented Apr 3, 2023

Is this the issue that affects rhel 8.9 as well?

No, the above issue affects only CentOS Stream 8; the failure of RHEL 8.9 is the same for every OS, and it's...

  • wrong environment selection

... this.

Every OS except rhel 9.3?

No, including, so likely a single change would probably fix tests_environments on all the OSes (unless they are affected by other issues already, like all the Fedora versions currently).

@richm richm merged commit cd01cb0 into linux-system-roles:main Apr 3, 2023
@ptoscano ptoscano deleted the pin-candlepin-before-java-17 branch April 3, 2023 16:30
@richm
Copy link
Contributor

richm commented Apr 3, 2023

The weekly ci job for this role will run in a few days - we'll see if some of the issues have been fixed by then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants