use official Ansible container for ansible-lint #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, run ansible-lint locally the same way that the ansible-lint github action runs. This helps when you get errors in the github CI, you can reproduce and fix locally. https://github.com/ansible/ansible-lint-action/blob/main/action.yml#L24 Get rid of the lsr_ansible-lint configuration. If you want to configure ansible-lint, you specify .ansible-lint in the role repo root directory. This also helps simplify and make the local action work just like the github action. By default, it will use podman to run the container. You can set `LSR_CONTAINER_RUNTIME` to use a different runtime. You can pass extra command line arguments to ansible-lint like this: `tox -e ansible-lint -- -vvv --exclude=my/dir/ ...`
richm
force-pushed
the
ansible-lint-test-containers
branch
from
c1ee994 to
39ade97
Compare
nhosoi
reviewed
Jan 12, 2023
| --exclude=.yamllint.yml \ | ||
| -c {[lsr_ansible-lint]configfile} \ | ||
| {env:RUN_ANSIBLE_LINT_EXTRA_ARGS:} {posargs} | ||
| {env:LSR_CONTAINER_RUNTIME:podman} run --rm --privileged \ |
There was a problem hiding this comment.
We may want to add the description to README.md. But it's a very minor issue...
By default, it will use podman to run the container. You can set LSR_CONTAINER_RUNTIME to use a different runtime
There was a problem hiding this comment.
updated
also deprecated several old env. vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, run ansible-lint locally the same way that the ansible-lint
github action runs. This helps when you get errors in the github CI,
you can reproduce and fix locally.
https://github.com/ansible/ansible-lint-action/blob/main/action.yml#L24
Get rid of the lsr_ansible-lint configuration. If you want to configure
ansible-lint, you specify .ansible-lint in the role repo root directory.
This also helps simplify and make the local action work just like the
github action.
By default, it will use podman to run the container. You can set
LSR_CONTAINER_RUNTIMEto use a different runtime.You can pass extra command line arguments to ansible-lint like this:
tox -e ansible-lint -- -vvv --exclude=my/dir/ ...