Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Please support for asian languages #250

Closed
1 task done
LeXwDeX opened this issue May 25, 2024 · 6 comments
Closed
1 task done

[FEAT] Please support for asian languages #250

LeXwDeX opened this issue May 25, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@LeXwDeX
Copy link

LeXwDeX commented May 25, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

For rendering covers that require support for Asian languages (e.g., Chinese, Japanese, Korean, etc.), additional font support is needed. You can use apt install fonts-noto-cjk-extra to add more support, which facilitates the creation of covers with non-English characters.

Reason for change

If this font support is not available, the characters on the rendered cover will appear as blocks.

Proposed code change

It's very simple, just add the step apt install fonts-noto-cjk-extra when building the Docker image.

@LeXwDeX LeXwDeX added the enhancement New feature or request label May 25, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented May 25, 2024

@LeXwDeX
Copy link
Author

LeXwDeX commented May 26, 2024

https://github.com/linuxserver/docker-mods/tree/universal-package-install

Hello, I know how to avoid this issue. I'm just suggesting that it could be built into the image by default, so there's no need to add extra steps.

@aptalca
Copy link
Member

aptalca commented May 26, 2024

There are no extra steps. Just add the two env vars to your compose yaml or docker run.

We will not add that package because it would nearly double the size of the image.

@aptalca aptalca closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker May 26, 2024
@theggs

This comment was marked as off-topic.

@z979054461
Copy link

https://github.com/linuxserver/docker-mods/tree/universal-package-install

Hello, I know how to avoid this issue. I'm just suggesting that it could be built into the image by default, so there's no need to add extra steps.

It not works for me. Please help
The install command is

if [ -e /dev/dri/renderD128 ]; then                                
                                                                   
docker create -i -t --name Jellyfin \                              
        -p 28096:8096 -p 28920:8920 \                              
        -v /etc/localtime:/etc/localtime:ro \                                                  
        -v /usr/builtin/etc/certificate/:/ssl/:ro \                
        -v /share/Docker/Jellyfin/Config:/config:rw \              
        -v /share/Docker/Jellyfin/Cache:/cache:rw \                
        -v /share/Media:/media:rw \                                
        -v /share:/sharefolder:rw \                                
        --device=/dev/dri/renderD128 \                             
        --restart=unless-stopped \                                        
        -e DOCKER_MODS=linuxserver/mods:universal-package-install \        
        -e INSTALL_PACKAGES=fonts-noto-cjk-extra \                 
        jellyfin/jellyfin:latest                                   
                                                                   
else                                                               
                                                                   
docker create -i -t --name Jellyfin \                              
        -p 28096:8096 -p 28920:8920 \                              
        -v /etc/localtime:/etc/localtime:ro \                      
        -v /usr/builtin/etc/certificate/:/ssl/:ro \                
        -v /share/Docker/Jellyfin/Config:/config:rw \                         
        -v /share/Docker/Jellyfin/Cache:/cache:rw \                           
        -v /share/Media:/media:rw \                                           
        -v /share:/sharefolder:rw \                                           
        -e DOCKER_MODS=linuxserver/mods:universal-package-install \           
        -e INSTALL_PACKAGES=fonts-noto-cjk-extra \                            
        --restart=unless-stopped \                                            
        jellyfin/jellyfin:latest                                              
                                                                              
fi                                                                                                                                       
                                                                              
docker start Jellyfin 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants