Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM_webRequest removed for now #64

Closed
Malix-Labs opened this issue Mar 20, 2023 · 8 comments
Closed

GM_webRequest removed for now #64

Malix-Labs opened this issue Mar 20, 2023 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@Malix-Labs
Copy link
Contributor

image

See Tampermonkey/tampermonkey#1086 (comment) leading to Tampermonkey/tampermonkey#397

@lisonge
Copy link
Owner

lisonge commented Mar 21, 2023

GM_webRequest removed for now

emmm, where is the description of removed ?

@lisonge lisonge added the help wanted Extra attention is needed label Mar 21, 2023
@Malix-Labs
Copy link
Contributor Author

Malix-Labs commented Mar 21, 2023

What do you mean?

I just know that for now this method doesn't exist for Tampermonkey, but as you can see there:

See Tampermonkey/tampermonkey#1086 (comment) leading to Tampermonkey/tampermonkey#397

They apparently mean to make it come back

@lisonge
Copy link
Owner

lisonge commented Mar 21, 2023

I add GM_webRequest to client because there is GM_webRequest at api:GM_webRequest

and it can be used in code

image


So what should I do ?

@Malix-Labs
Copy link
Contributor Author

Malix-Labs commented Mar 21, 2023

I add GM_webRequest to client because there is GM_webRequest at api:GM_webRequest

and it can be used in code

image


So what should I do ?

Ah that's weird.
Do you think the in-editor error message is a false-positive and should be removed then, as the API function is working well?
If yes, I'm going to open an issue in their repository

@Malix-Labs
Copy link
Contributor Author

What happen when you remove the "grant" meta line in the code in your screenshot?

@lisonge
Copy link
Owner

lisonge commented Mar 21, 2023

What happen when you remove the "grant" meta line in the code in your screenshot?

image

@lisonge
Copy link
Owner

lisonge commented Mar 21, 2023

Do you think the in-editor error message is a false-positive and should be removed then, as the API function is working well?

I don't care about eslint, you can use /*eslint-disable */

image

@Malix-Labs
Copy link
Contributor Author

Ye, then I think the error message is a bug.
I will open an issue in their repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants