Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AttributePart to only have a single value #400

Merged
merged 26 commits into from
Aug 17, 2018
Merged

Refactor AttributePart to only have a single value #400

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
aa6da5a
WIP: Refactor AttributePart to only have a single value. Add Attribut…
justinfagnani Jul 14, 2018
5ef6251
WIP: lit-html tests passing.
justinfagnani Jul 17, 2018
d75bf0a
All tests passing
justinfagnani Jul 18, 2018
3f1f015
Ensure attributes & properties are only set once for multiple bindings
justinfagnani Jul 18, 2018
3f0a8ec
Ensure PropertyCommitter sets properties
justinfagnani Jul 18, 2018
123f5a1
Format
justinfagnani Jul 18, 2018
1f956ad
Remove unused imports
justinfagnani Jul 18, 2018
115be14
Fix EventPart
justinfagnani Jul 19, 2018
3ec481f
Re-enable shady tests
justinfagnani Jul 19, 2018
0f08697
Add PropertyPart
justinfagnani Jul 27, 2018
89fe937
Require NodePart#commit to be called before writing values to DOM
justinfagnani Jul 28, 2018
a625262
Checkpoint: inline getValue into NodePart#setValue
justinfagnani Jul 30, 2018
befbbc6
All tests passing
justinfagnani Jul 30, 2018
9f11020
Don’t use custom elements in lit-html_test.ts
justinfagnani Jul 31, 2018
fbc3eae
Checkpoint
justinfagnani Jul 31, 2018
fdb607e
WIP (remove getValue…)
justinfagnani Aug 2, 2018
9f1be79
Fix BooleanAttributePart?
justinfagnani Aug 14, 2018
d01c7cd
Revert adding the keyValue argument to setValue
justinfagnani Aug 14, 2018
d50c9c7
Add web components polyfills for IE11
justinfagnani Aug 14, 2018
438b052
Update webcomponents polyfill
justinfagnani Aug 15, 2018
52f178c
¯\_(ツ)_/¯
justinfagnani Aug 15, 2018
d255783
Don’t use new Set(iterable) in tests
justinfagnani Aug 15, 2018
4219f6d
Remove commented out code
justinfagnani Aug 15, 2018
797af69
Address review comments
justinfagnani Aug 17, 2018
a70d615
Update web-component-tester to version compatible with Node 10
justinfagnani Aug 17, 2018
a627939
Format
justinfagnani Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"test": "npm run build && npm run lint && wct --npm",
"quicktest": "wct -l chrome -p --npm",
"checksize": "uglifyjs core.js -mc --toplevel | gzip -9 | wc -c",
"min": "uglifyjs core.js -mc --toplevel",
"format": "find src test | grep '\\.js$\\|\\.ts$' | xargs clang-format --style=file -i",
"lint": "tslint --project ./",
"prepare": "npm run build"
Expand All @@ -34,10 +35,7 @@
"devDependencies": {
"@types/chai": "^4.1.0",
"@types/mocha": "^5.2.0",
"@webcomponents/shadycss": "^1.2.1",
"@webcomponents/template": "^1.3.1",
"@webcomponents/webcomponentsjs": "^2.0.2",
"babel-polyfill": "^6.26.0",
"@webcomponents/webcomponentsjs": "^2.0.4",
"chai": "^4.1.2",
"mocha": "^5.2.0",
"tslint": "^5.9.1",
Expand Down
Loading