Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀[Release v.2.10.0-20240421] Merge into Main #181

Merged
merged 1,678 commits into from
May 21, 2024
Merged

🚀[Release v.2.10.0-20240421] Merge into Main #181

merged 1,678 commits into from
May 21, 2024

Conversation

kcw-grunt
Copy link
Contributor

@kcw-grunt kcw-grunt commented Apr 22, 2024

Updates ....alot

  • Removed sensitive data
  • In Progress Refactoring Code
  • Removed cruft
  • bump version
  • working ops address being generated
  • tieredOps working
  • refactor cleanup
  • renaming and refactor…project running!
  • created and sent a transaction
  • Renamed some code from Bitcoin to Litecoin
  • remove whitespace
  • created a set to create the intersection
  • Filtered out the address as targeted
  • added textview for Service Fee
  • condensed the inits
  • Renamed from iso to more meaningful names
  • More refactor
  • Moved Fee Manager
  • Changed the rate polls
  • renamed getIso to getIsoSymbol
  • Removed saveEvent
  • Adjusted hot spot of Amount Edit
  • added full names to buttons.
  • added extra check before donating
  • commented out the new params
  • Fixes the Unsopported ISO bug
  • Removed old code
  • Relabeled Bitcoin to Litecoin in places
  • Cleaned up the detail text in Transaction Item
  • updated confirmation label
  • Tried hide the keyboard
  • updated tiers : 1713522152
  • Debug of the com.breadwallet.tools.security.AuthManager.authPrompt
  • Put AnnounceUpdatesViewActivity in button create and restore
  • Added enable on back invoke call on Manifest
  • Added src/main/assets inside fast_follow_asset_pack_01 folder
  • Create Folder src/main/assets
  • delete test file
  • Create directory src/main/assets inside fast_follow_asset_pack_01
  • Rename file to empty_file

mosadialiou and others added 30 commits June 10, 2020 21:03
* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit d355738.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit d355738.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

Co-authored-by: Kerry Washington <[email protected]>
josikie and others added 14 commits March 20, 2024 18:08
…tro Activity) (#167)

* Added audios and audios data source

* Changed Intro's UI, Added Adapter, and Added country resources.

* Convert CountryLanguageAdapter to Kotlin, added shadow and made text item bold when selected

* Added audio feature to play the language on each item

* Added pop up yes or no UI

* Added pop up yes or cancel

* Change text's sizes
* Update Gitignore

* Updated lockscreen

* Changed color to white, Added litewallet dark blue color
refactored to get compile

Signed-off-by: kcw-grunt <[email protected]>
* Finally fixed the PN dep error caused by Firebase

- Added more analytics for the push notifications
- Simple clean up refactoring

Signed-off-by: kcw-grunt <[email protected]>

Added the AdvertID into the BreadApp singleton

Signed-off-by: kcw-grunt <[email protected]>

* Added access and location of the key file

- addess access object, JSON object, method to read and operate
- updated gitignore
Signed-off-by: kcw-grunt <[email protected]>

* updated the latest commit

Signed-off-by: kcw-grunt <[email protected]>

* DO NOT SQUASH - bugfix: com.breadwallet.tools.manager.BRSharedPrefs.getIso

Biggest bug in when the user has ru as the as a default language

https://console.firebase.google.com/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/78150fde415a8e4c174f19e2ff2e0988?time=1703682751000:1706274751000&sessionEventKey=65B37C4E00DC00016CE457C04AD2C024_1906783813838484053

- Testing to set to RU for ru

Signed-off-by: kcw-grunt <[email protected]>

* cleanup after locating bug

Signed-off-by: kcw-grunt <[email protected]>

---------

Signed-off-by: kcw-grunt <[email protected]>
- Should be dismiss to the parent
- Added close buttons
- refactored the onSaveInstances

Signed-off-by: kcw-grunt <[email protected]>
Signed-off-by: kcw-grunt <[email protected]>
added debug paths

Signed-off-by: kcw-grunt <[email protected]>
* Put AnnounceUpdatesViewActivity in button create and restore

* Added enable on back invoke call on Manifest

* Added src/main/assets inside fast_follow_asset_pack_01 folder

* Create Folder src/main/assets

* delete test file

* Create directory src/main/assets inside fast_follow_asset_pack_01

* Rename file to empty_file
* Removed sensitive data

Signed-off-by: kcw-grunt <[email protected]>

* In Progress Refactoring Code

- Removed cruft
- bump version
- working ops address being generated
Signed-off-by: kcw-grunt <[email protected]>

* tieredOps working

- refactor cleanup
- renaming and refactor…project running!
- created and sent a transaction
- Renamed some code from Bitcoin to Litecoin
- remove whitespace
- created a set to create the intersection
- Filtered out the address as targeted
- added textview for Service Fee
- condensed the inits
- Renamed from iso to more meaningful names

Signed-off-by: kcw-grunt <[email protected]>

* More refactor

- Moved Fee Manager
- Changed the rate polls
- renamed getIso to getIsoSymbol
- Removed saveEvent
- Adjusted hot spot of Amount Edit
- added full names to buttons.
- added extra check before donating
- commented out the new params
- Fixes the Unsopported ISO bug
- Removed old code

Signed-off-by: kcw-grunt <[email protected]>

* Relabeled Bitcoin to Litecoin in places

- Cleaned up the detail text in Transaction Item
- updated confirmation label
- Tried hide the keyboard

Signed-off-by: kcw-grunt <[email protected]>

* bumped version

updated tiers : 1713522152

Signed-off-by: kcw-grunt <[email protected]>

* Debug of the com.breadwallet.tools.security.AuthManager.authPrompt

-version bump
-moved google serivces plugin to the bottom per Pusher Suggest
-code bump

Signed-off-by: kcw-grunt <[email protected]>

---------

Signed-off-by: kcw-grunt <[email protected]>
@kcw-grunt kcw-grunt changed the title Release/v2.10.0 🚀[Release v.2.10.0-20240422] Merge into Main Apr 22, 2024
@kcw-grunt kcw-grunt changed the title 🚀[Release v.2.10.0-20240422] Merge into Main 🚀[Release v.2.10.0-20240421] Merge into Main Apr 22, 2024
Signed-off-by: kcw-grunt <[email protected]>

# Conflicts:
#	.gitignore
#	.idea/androidTestResultsUserPreferences.xml
#	app/build.gradle
#	app/src/main/AndroidManifest.xml
#	app/src/main/java/com/breadwallet/BreadApp.java
#	app/src/main/java/com/breadwallet/entities/IntroLanguage.kt
#	app/src/main/java/com/breadwallet/entities/IntroLanguageResource.kt
#	app/src/main/java/com/breadwallet/presenter/activities/AnnounceUpdatesViewActivity.kt
#	app/src/main/java/com/breadwallet/presenter/activities/BreadActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/LoginActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/intro/IntroActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/settings/DisplayCurrencyActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/settings/FingerprintActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/settings/SettingsActivity.java
#	app/src/main/java/com/breadwallet/presenter/activities/settings/SpendLimitActivity.java
#	app/src/main/java/com/breadwallet/presenter/entities/PartnerNames.kt
#	app/src/main/java/com/breadwallet/presenter/entities/TxItem.java
#	app/src/main/java/com/breadwallet/presenter/fragments/DynamicDonationFragment.java
#	app/src/main/java/com/breadwallet/presenter/fragments/FragmentFingerprint.java
#	app/src/main/java/com/breadwallet/presenter/fragments/FragmentPin.java
#	app/src/main/java/com/breadwallet/presenter/fragments/FragmentRequestAmount.java
#	app/src/main/java/com/breadwallet/presenter/fragments/FragmentSend.kt
#	app/src/main/java/com/breadwallet/presenter/fragments/FragmentTransactionItem.java
#	app/src/main/java/com/breadwallet/tools/adapter/CountryLanguageAdapter.kt
#	app/src/main/java/com/breadwallet/tools/adapter/TransactionListAdapter.java
#	app/src/main/java/com/breadwallet/tools/manager/BRApiManager.java
#	app/src/main/java/com/breadwallet/tools/manager/BREventManager.java
#	app/src/main/java/com/breadwallet/tools/manager/BRSharedPrefs.java
#	app/src/main/java/com/breadwallet/tools/manager/FeeManager.java
#	app/src/main/java/com/breadwallet/tools/manager/SyncManager.java
#	app/src/main/java/com/breadwallet/tools/security/BRSender.java
#	app/src/main/java/com/breadwallet/tools/security/BitcoinUrlHandler.java
#	app/src/main/java/com/breadwallet/tools/security/PostAuth.java
#	app/src/main/java/com/breadwallet/tools/threads/ImportPrivKeyTask.java
#	app/src/main/java/com/breadwallet/tools/threads/PaymentProtocolTask.java
#	app/src/main/java/com/breadwallet/tools/util/BRCurrency.java
#	app/src/main/java/com/breadwallet/tools/util/BRExchange.java
#	app/src/main/java/com/breadwallet/tools/util/Utils.java
#	app/src/main/java/com/breadwallet/wallet/BRWalletManager.java
#	app/src/main/jni/transition/wallet.c
#	app/src/main/jni/transition/wallet.h
#	app/src/main/res/layout/activity_announce_updates_view.xml
#	app/src/main/res/layout/fragment_send.xml
#	app/src/main/res/layout/syncing_item.xml
#	app/src/main/res/layout/transaction_details_item.xml
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values-es/strings.xml
#	app/src/main/res/values-fr/strings.xml
#	app/src/main/res/values-in/strings.xml
#	app/src/main/res/values-it/strings.xml
#	app/src/main/res/values-ja/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-pt/strings.xml
#	app/src/main/res/values-ru/strings.xml
#	app/src/main/res/values-tr/strings.xml
#	app/src/main/res/values-uk/strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
#	app/src/main/res/values-zh-rTW/strings.xml
#	app/src/main/res/values/strings.xml
@kcw-grunt kcw-grunt requested a review from josikie April 22, 2024 13:36
@kcw-grunt kcw-grunt added android Android related only 🚀 release Related to a production release labels Apr 22, 2024
@kcw-grunt kcw-grunt marked this pull request as ready for review April 22, 2024 13:36
Copy link
Contributor

@josikie josikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really a lot...

Thank you! @kcw-grunt

@kcw-grunt kcw-grunt merged commit 9d99ee1 into main May 21, 2024
2 checks passed
@kcw-grunt kcw-grunt deleted the release/v2.10.0 branch May 31, 2024 17:02
kcw-grunt added a commit that referenced this pull request Nov 24, 2024
* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

* move constants where they are used

* respect constant nomenclature

* make “ltcPriceLbl” same textSize as “ltcAmount”

* WIP: Login/Register views (#159)

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

Co-authored-by: Kerry Washington <[email protected]>

* version bump and upgrade

* make sure listeners are not NULL

* make sure to call super

* remove unused code

* Move transactions to HistoryFragment

* fix typo

* Remove fonts in assets folder. Delete BREdit and BRText and use styles

* Reformat Code: layout files

* Reformat code: anim files

* Reformat code: animator files

* code refactor

* connect login and register views to API

* make partnerapi as git submodule

* update partnerapi

* BRKeystore: remove duplicated entry (FAIL_COUNT_ALIAS)

* after successful registration, show up a confirmation and send user back to login

* remove test code

* add ktlint and format kotlin files

* update partnerapi

* fix typo

* set views Ids

* Transfer view: add “Logout” button and handle navigation

* transfer view: add padding bottom to “Transfer” button

* gradle: code format

* use default NDK version=21.0.6113669

* use Timber instead of Log

* convert BreadActivity to FragmentActivity in order to handle back pressed from fragments

* handle back button on BuyFragment

* upgrade firebase libs version to latest

* Handle AUD, GBP, HKD, IDR, RUB and SGD currencies

* upgrade gradle/gradle build tool to respectively 6.5 and 4.1.0

* handle document upload for KYC verification

* update support/policy/social links

* update README: replace iOS by Android

* use zendesk support email address

* make sure the selected fiat option is always visible

* setup kotlin

* cleanup + use timber

* use androidx fragment

* update libs

* FragmentSend: IDE convertion to kotlin

* FragmentSend: tweak kotlin conversion

* FragmentSend: UD integration

* BRButton: disable touch effect when disabled

* DynamicDonationFragment: convert to android

* DynamicDonationFragment: use lambda

* UDResolution: only resolve LTC domains

* FragmentSend: translation

* translate “Lookup”

* rename tryBitcoinURL to tryLitecoinURL

* add kotlin doc

* Release v1.20.0 (simplex) (#190)

* FragmentBuy: use https for simplex prod URL

* bump app version 1.20.0(630)

* Release v1.20.0 - Simplex (#187)

* upgraded Gradle

* upgraded to androidx and synced gradle

* Reverted test to menu

* Added brand fonts

* added color names

* replaced logo with new logo and added litewallet blue and removed some gradient views

# Conflicts:
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* gradle sync

* refactoring views..still need to add version code to launch screen

# Conflicts:
#	.idea/caches/build_file_checksums.ser
#	.idea/caches/gradle_models.ser
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* updated per latest gradle

* added in the version number at login

* removed superflous L

* polished header

* moved version label for intro

# Conflicts:
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_deps
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_log
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_deps
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_log
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_log

* upgrade to 26 min and 29 Android

* worked in the donate layouts but not functional

* WIP added buy tab button

* WIP buy tab

* WIP added in the buy tab prior to the webview

* added in webview got Buy Tab

* comment out the Buy Tab until server is ready

* update for signing fixed naming

* updated icons and Litewallet naming

* added USE Biometric permission

* moved layout

* added in the old toolbar and logo but flipper still being debugged

* WIP debuggin layout of the header toolbar

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* V1.18.1 (#65)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* show up buy button

* Upgrade dependencies

* added donation info and functionality (#67)

* added donation info and functionality

* per review comments

* Tweak L/$ price labels animation (#69)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* Tweak L/$ price labels animation

* remove useless attributes clipChildren and clipToPadding

* Revert "remove useless attributes clipChildren and clipToPadding"

This reverts commit 0a4fec50b6d4e322ed19315d802f09544b8c60f6.

* Ea/update fonts (#70)

* Use BarlowSemiCondensed in lieu of CircularPro (excluding CircularPro-Book)

* Swap CircularPro-Book.otf for BarlowSemiCondensed-Medium.ttf

* added circleci and build bump

* updated cofing.yml v2

* update config.yml v 3

* update v4

* update v6

* linter error fix for ci, small confirm field polish

* silence linter on InvalidPackages

* error fix update gradle

* turn off abortonError

* List of partners screen

* Handle tap on simplex partner item

* code clean-up

* refactor the buy URL generation

* pass choosen currency code to buy fragment

* Remove horizontal linear layout and base align “choose fiat” with CAD, EUR, JPY and USD

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use Timber instead of Log

* convert BreadActivity to FragmentActivity in order to handle back pressed from fragments

* handle back button on BuyFragment

* upgrade firebase libs version to latest

* Handle AUD, GBP, HKD, IDR, RUB and SGD currencies

* upgrade gradle/gradle build tool to respectively 6.5 and 4.1.0

* handle document upload for KYC verification

* update support/policy/social links

* update README: replace iOS by Android

* use zendesk support email address

* make sure the selected fiat option is always visible

* FragmentBuy: use https for simplex prod URL

* bump app version 1.20.0(630)

Co-authored-by: Kerry <[email protected]>
Co-authored-by: Ebenezer <[email protected]>

* bump app version 1.21.0(631)

* bugfix: send view stays after send confirmation disappears

* remove UD error toasts

* clear the LTC address before each Lookup

* show up a confirmation toast if UD resolution is successful

* bump version v1.21.0(632)

* UD: add Analytics events

* FragmentSend: disable Lookup button until the domain string is at least 4 chars

* bump version v1.21.0(633)

* Release v1.21.0 (#193)

* upgraded Gradle

* upgraded to androidx and synced gradle

* Reverted test to menu

* Added brand fonts

* added color names

* replaced logo with new logo and added litewallet blue and removed some gradient views

# Conflicts:
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* gradle sync

* refactoring views..still need to add version code to launch screen

# Conflicts:
#	.idea/caches/build_file_checksums.ser
#	.idea/caches/gradle_models.ser
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* updated per latest gradle

* added in the version number at login

* removed superflous L

* polished header

* moved version label for intro

# Conflicts:
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_deps
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_log
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_deps
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_log
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_log

* upgrade to 26 min and 29 Android

* worked in the donate layouts but not functional

* WIP added buy tab button

* WIP buy tab

* WIP added in the buy tab prior to the webview

* added in webview got Buy Tab

* comment out the Buy Tab until server is ready

* update for signing fixed naming

* updated icons and Litewallet naming

* added USE Biometric permission

* moved layout

* added in the old toolbar and logo but flipper still being debugged

* WIP debuggin layout of the header toolbar

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* V1.18.1 (#65)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* show up buy button

* Upgrade dependencies

* added donation info and functionality (#67)

* added donation info and functionality

* per review comments

* Tweak L/$ price labels animation (#69)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* Tweak L/$ price labels animation

* remove useless attributes clipChildren and clipToPadding

* Revert "remove useless attributes clipChildren and clipToPadding"

This reverts commit 0a4fec50b6d4e322ed19315d802f09544b8c60f6.

* Ea/update fonts (#70)

* Use BarlowSemiCondensed in lieu of CircularPro (excluding CircularPro-Book)

* Swap CircularPro-Book.otf for BarlowSemiCondensed-Medium.ttf

* added circleci and build bump

* updated cofing.yml v2

* update config.yml v 3

* update v4

* update v6

* linter error fix for ci, small confirm field polish

* silence linter on InvalidPackages

* error fix update gradle

* turn off abortonError

* List of partners screen

* Handle tap on simplex partner item

* code clean-up

* refactor the buy URL generation

* pass choosen currency code to buy fragment

* Remove horizontal linear layout and base align “choose fiat” with CAD, EUR, JPY and USD

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use Timber instead of Log

* convert BreadActivity to FragmentActivity in order to handle back pressed from fragments

* handle back button on BuyFragment

* upgrade firebase libs version to latest

* Handle AUD, GBP, HKD, IDR, RUB and SGD currencies

* upgrade gradle/gradle build tool to respectively 6.5 and 4.1.0

* handle document upload for KYC verification

* update support/policy/social links

* update README: replace iOS by Android

* use zendesk support email address

* make sure the selected fiat option is always visible

* setup kotlin

* cleanup + use timber

* use androidx fragment

* update libs

* FragmentSend: IDE convertion to kotlin

* FragmentSend: tweak kotlin conversion

* FragmentSend: UD integration

* BRButton: disable touch effect when disabled

* DynamicDonationFragment: convert to android

* DynamicDonationFragment: use lambda

* UDResolution: only resolve LTC domains

* FragmentSend: translation

* translate “Lookup”

* rename tryBitcoinURL to tryLitecoinURL

* add kotlin doc

* Release v1.20.0 (simplex) (#190)

* FragmentBuy: use https for simplex prod URL

* bump app version 1.20.0(630)

* bump app version 1.21.0(631)

* bugfix: send view stays after send confirmation disappears

* remove UD error toasts

* clear the LTC address before each Lookup

* show up a confirmation toast if UD resolution is successful

* bump version v1.21.0(632)

* UD: add Analytics events

* FragmentSend: disable Lookup button until the domain string is at least 4 chars

* bump version v1.21.0(633)

Co-authored-by: Kerry <[email protected]>
Co-authored-by: Ebenezer <[email protected]>

* fix build errors

* Tapping on BuyTab shows up the BuyTabFragment

* BuyTabFragment: add horizontal divider

* replace listener with lambda

* BuyTab: change fiat selector

* FragmentBuy: add toolbar and show progress while page is loading

* rename menu tab from “Spend” to “Card”

* change register view header title

* register view: change fields order according to iOS

* register view: remove address2 field

* login view: handle forgot password

* tweak login/register views

* transfer view v1

* update partnerapi lib

* Replace “Bread” with “Litewallet”

* Replace “Bread” with “Litewallet”

* remove empty java class

* bugFix(Send view): Send with Scan crashes

* ScanQRActivity: code clean-up

* login/register views: extract texts into strings resource

* Buy tab: remove “choose fiat” from partner item view

* login/register views: localize texts

* reduce password length from 8 to 6 at least

* bump version v2.0.0(634)

* bugfix: make sure the market price displays only 2 decimals

* bump version v2.0.0(635)

* Release v2.0.0 card v1 (#202)

* upgraded Gradle

* upgraded to androidx and synced gradle

* Reverted test to menu

* Added brand fonts

* added color names

* replaced logo with new logo and added litewallet blue and removed some gradient views

# Conflicts:
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* gradle sync

* refactoring views..still need to add version code to launch screen

# Conflicts:
#	.idea/caches/build_file_checksums.ser
#	.idea/caches/gradle_models.ser
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* updated per latest gradle

* added in the version number at login

* removed superflous L

* polished header

* moved version label for intro

# Conflicts:
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_deps
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_log
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_deps
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_log
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_log

* upgrade to 26 min and 29 Android

* worked in the donate layouts but not functional

* WIP added buy tab button

* WIP buy tab

* WIP added in the buy tab prior to the webview

* added in webview got Buy Tab

* comment out the Buy Tab until server is ready

* update for signing fixed naming

* updated icons and Litewallet naming

* added USE Biometric permission

* moved layout

* added in the old toolbar and logo but flipper still being debugged

* WIP debuggin layout of the header toolbar

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* V1.18.1 (#65)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* show up buy button

* Upgrade dependencies

* added donation info and functionality (#67)

* added donation info and functionality

* per review comments

* Tweak L/$ price labels animation (#69)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* Tweak L/$ price labels animation

* remove useless attributes clipChildren and clipToPadding

* Revert "remove useless attributes clipChildren and clipToPadding"

This reverts commit 0a4fec50b6d4e322ed19315d802f09544b8c60f6.

* Ea/update fonts (#70)

* Use BarlowSemiCondensed in lieu of CircularPro (excluding CircularPro-Book)

* Swap CircularPro-Book.otf for BarlowSemiCondensed-Medium.ttf

* added circleci and build bump

* updated cofing.yml v2

* update config.yml v 3

* update v4

* update v6

* linter error fix for ci, small confirm field polish

* silence linter on InvalidPackages

* error fix update gradle

* turn off abortonError

* List of partners screen

* Handle tap on simplex partner item

* code clean-up

* refactor the buy URL generation

* pass choosen currency code to buy fragment

* Remove horizontal linear layout and base align “choose fiat” with CAD, EUR, JPY and USD

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

* move constants where they are used

* respect constant nomenclature

* make “ltcPriceLbl” same textSize as “ltcAmount”

* WIP: Login/Register views (#159)

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

Co-authored-by: Kerry Washington <[email protected]>

* version bump and upgrade

* make sure listeners are not NULL

* make sure to call super

* remove unused code

* Move transactions to HistoryFragment

* fix typo

* Remove fonts in assets folder. Delete BREdit and BRText and use styles

* Reformat Code: layout files

* Reformat code: anim files

* Reformat code: animator files

* code refactor

* connect login and register views to API

* make partnerapi as git submodule

* update partnerapi

* BRKeystore: remove duplicated entry (FAIL_COUNT_ALIAS)

* after successful registration, show up a confirmation and send user back to login

* remove test code

* add ktlint and format kotlin files

* update partnerapi

* fix typo

* set views Ids

* Transfer view: add “Logout” button and handle navigation

* transfer view: add padding bottom to “Transfer” button

* gradle: code format

* use default NDK version=21.0.6113669

* use Timber instead of Log

* convert BreadActivity to FragmentActivity in order to handle back pressed from fragments

* handle back button on BuyFragment

* upgrade firebase libs version to latest

* Handle AUD, GBP, HKD, IDR, RUB and SGD currencies

* upgrade gradle/gradle build tool to respectively 6.5 and 4.1.0

* handle document upload for KYC verification

* update support/policy/social links

* update README: replace iOS by Android

* use zendesk support email address

* make sure the selected fiat option is always visible

* setup kotlin

* cleanup + use timber

* use androidx fragment

* update libs

* FragmentSend: IDE convertion to kotlin

* FragmentSend: tweak kotlin conversion

* FragmentSend: UD integration

* BRButton: disable touch effect when disabled

* DynamicDonationFragment: convert to android

* DynamicDonationFragment: use lambda

* UDResolution: only resolve LTC domains

* FragmentSend: translation

* translate “Lookup”

* rename tryBitcoinURL to tryLitecoinURL

* add kotlin doc

* Release v1.20.0 (simplex) (#190)

* FragmentBuy: use https for simplex prod URL

* bump app version 1.20.0(630)

* bump app version 1.21.0(631)

* bugfix: send view stays after send confirmation disappears

* remove UD error toasts

* clear the LTC address before each Lookup

* show up a confirmation toast if UD resolution is successful

* bump version v1.21.0(632)

* UD: add Analytics events

* FragmentSend: disable Lookup button until the domain string is at least 4 chars

* bump version v1.21.0(633)

* fix build errors

* Tapping on BuyTab shows up the BuyTabFragment

* BuyTabFragment: add horizontal divider

* replace listener with lambda

* BuyTab: change fiat selector

* FragmentBuy: add toolbar and show progress while page is loading

* rename menu tab from “Spend” to “Card”

* change register view header title

* register view: change fields order according to iOS

* register view: remove address2 field

* login view: handle forgot password

* tweak login/register views

* transfer view v1

* update partnerapi lib

* Replace “Bread” with “Litewallet”

* Replace “Bread” with “Litewallet”

* remove empty java class

* bugFix(Send view): Send with Scan crashes

* ScanQRActivity: code clean-up

* login/register views: extract texts into strings resource

* Buy tab: remove “choose fiat” from partner item view

* login/register views: localize texts

* reduce password length from 8 to 6 at least

* bump version v2.0.0(634)

* bugfix: make sure the market price displays only 2 decimals

* bump version v2.0.0(635)

Co-authored-by: Kerry <[email protected]>
Co-authored-by: Ebenezer <[email protected]>

* refacto(FragmentMenu): use lambda + code reformat

* feature: Replace Customer Email with Zendesk HC

* [TechDebt] Add issue templates (#208)

* Add issue templates

* polished per comments

* [Bugfix] Header price update occludes the other text (#207)

* Change the font mixe

* Set the font to autosizing

- helps by setting the max width

* add balance label in header

* fix error: Attribute autoSizeMinTextSize is only used in API level 26 and higher (current min is 23)

* fix crash from Firebase: BreadActivity.java line 444
https://github.com/litecoin-foundation/loafwallet-android/issues/211

* fix crash in RegisterFragment.kt at line 68
https://github.com/litecoin-foundation/loafwallet-android/issues/212

* PR reviews

* bump version v2.1.0(636)

* add card disclaimer dialog

* bump version v2.1.1(637)

* Release v2.1.0 (into master) (#227)

* upgraded Gradle

* upgraded to androidx and synced gradle

* Reverted test to menu

* Added brand fonts

* added color names

* replaced logo with new logo and added litewallet blue and removed some gradient views

# Conflicts:
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* gradle sync

* refactoring views..still need to add version code to launch screen

# Conflicts:
#	.idea/caches/build_file_checksums.ser
#	.idea/caches/gradle_models.ser
#	app/.cxx/cmake/loafDebug/x86/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86/.ninja_log

* updated per latest gradle

* added in the version number at login

* removed superflous L

* polished header

* moved version label for intro

# Conflicts:
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_deps
#	app/.cxx/cmake/loafDebug/arm64-v8a/.ninja_log
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_deps
#	app/.cxx/cmake/loafDebug/armeabi-v7a/.ninja_log
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_deps
#	app/.cxx/cmake/loafDebug/x86_64/.ninja_log

* upgrade to 26 min and 29 Android

* worked in the donate layouts but not functional

* WIP added buy tab button

* WIP buy tab

* WIP added in the buy tab prior to the webview

* added in webview got Buy Tab

* comment out the Buy Tab until server is ready

* update for signing fixed naming

* updated icons and Litewallet naming

* added USE Biometric permission

* moved layout

* added in the old toolbar and logo but flipper still being debugged

* WIP debuggin layout of the header toolbar

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* V1.18.1 (#65)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* show up buy button

* Upgrade dependencies

* added donation info and functionality (#67)

* added donation info and functionality

* per review comments

* Tweak L/$ price labels animation (#69)

* Unversionned app/.cxx folder since it s auto

* Unversionned .idea/caches folder since it is autogenerated

* Fix layout issue: the price = LTC labels

* directly set the text size. the system will scale it

* change ltc price color to white

* update the btc naming to ltc

* use meaningful naming

* remove commented code

* Fix: text prices should be about 20% smaller

* price flipper margins should be lower on the bottom

* Tweak L/$ price labels animation

* remove useless attributes clipChildren and clipToPadding

* Revert "remove useless attributes clipChildren and clipToPadding"

This reverts commit 0a4fec50b6d4e322ed19315d802f09544b8c60f6.

* Ea/update fonts (#70)

* Use BarlowSemiCondensed in lieu of CircularPro (excluding CircularPro-Book)

* Swap CircularPro-Book.otf for BarlowSemiCondensed-Medium.ttf

* added circleci and build bump

* updated cofing.yml v2

* update config.yml v 3

* update v4

* update v6

* linter error fix for ci, small confirm field polish

* silence linter on InvalidPackages

* error fix update gradle

* turn off abortonError

* List of partners screen

* Handle tap on simplex partner item

* code clean-up

* refactor the buy URL generation

* pass choosen currency code to buy fragment

* Remove horizontal linear layout and base align “choose fiat” with CAD, EUR, JPY and USD

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

* move constants where they are used

* respect constant nomenclature

* make “ltcPriceLbl” same textSize as “ltcAmount”

* WIP: Login/Register views (#159)

* Dynamic donation (#118)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* increase donation but height

* version bump (#121)

* Fee types (#123)

* send screen: change donation button

* cleanup

* redundant string.format call

* dynamic donation feature

* localization

* set fee types color to litewallet blue

* move icons to xxx folder

* set donate/send buttons color to litewallet blue

* use spinner instead of numberpicker

* make spinner full width

* increase margin top of slider

* increase slider thumb size

* send screen: tweak ISO but

* send screen: increase donate button height

* Fix wrong donation amount

* add luxury fee’s type

* set default values

* dynamic donation: make sure fee is regular

* add note to refactor later

* WIP: Timber crashlytics (#124)

* timber integration + replace Log with Timber

* Replace all Log with Timber.
In production environment Timber.e() or Timber.i() will automatically report any crash or message to FirebaseCrashlytics

* better description

* Kcw grunt/fbug fixes bugfixes (#126)

* WIP working out the cross lang acceptance.

WIP removing Firebase Manager code.

Revert "WIP working out the cross lang acceptance."

This reverts commit 4cfbafca0c841df6945216c63959fcede0487470.

WIP working out the conflicts

Analytics working getting more locations.

* tested all custom events refactored to the standard firebase way

* removed dev code

* added Analytics Manager class

* update per review notes

* moved the costants and removed enum

* version bump

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* V1.19.0 (#135)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

Co-authored-by: mosadialiou <[email protected]>

* version bump and send test checks (#138)

* new donate addresses (#136)

* Revert 129 fix intro bug (#131)

* fix intro screen (#129)

* Barry/fix ltc testnet (#128)

* Change bitcoin-testnet with litecoin-testnet

* cleanup

* Revert "fix intro screen (#129)"

This reverts commit f79006b68f277692db888daa7181341e5d8d815c.

* Fix intro bug (#130)

* fix intro screen

* fix wrong stroke color

* add intro message

* clean up

* remove globalLayoutListener only if the tree observer is alive

* clean up

Co-authored-by: mosadialiou <[email protected]>

* update loafwallet core (#132)

* version bump

* Hotfix: Users unable to send (#134)

* Fix: Users unable to send

* clean up

* use timber instead

* new donate addresses

* add ADDRESS_SCHEME key to donation event

* fix inverted key-value

* clean up

Co-authored-by: Kerry Washington <[email protected]>

* version bump

* Added Litewallet

* fix broken link

* updated README.md (#145)

* updated README.md

* added links

* uodate header image

* new hdr

* added donations

* move donations

* change link

* add private link

* polish link

* copy edit

* add indo

* address

* fix addresses

* Bugfix: [UI Alignment] Extra comma in send view (#153)

* fix extra comma in send view

* Refactor getReceiver method

* remove extra linebreak

* code cleanup

* remove dead code

* reverse check order for perf.

* Fix: remove “donate to” prepended to the donation account

* remove “PLATFORM” which is already added by Firebase Analytics

* to v1.19.3 (612) (#154)

* use bottom navigation view

* update buy/spend/receive navigation icons

* Change send/receive navigation icon names

* localize history tab title

* Just “Acheter”

* Add fonts as resources

* setup kotlin

* upgrade grade + dependencies

* login/register views

* Replace search icon with menu icon and show up LTC price

* login/register UX

* Prevent view not rendering in layout editor

* code cleanup

* missing resources

* reduce toolbar height

* Specify a material colors for the app

* Remove unused file

* Transfer view

* update litecoin card image

Co-authored-by: Kerry Washington <[email protected]>

* version bump and upgrade

* make sure listeners are not NULL

* make sure to call super

* remove unused code

* Move transactions to HistoryFragment

* fix typo

* Remove fonts in assets folder. Delete BREdit and BRText and use styles

* Reformat Code: layout files

* Reformat code: anim files

* Reformat code: animator files

* code refactor

* connect login and register views to API

* make partnerapi as git submodule

* update partnerapi

* BRKeystore: remove duplicated entry (FAIL_COUNT_ALIAS)

* after successful registration, show up a confirmation and send user back to login

* remove test code

* add ktlint and format kotlin files

* update partnerapi

* fix typo

* set views Ids

* Transfer view: add “Logout” button and handle navigation

* transfer view: add padding bottom to “Transfer” button

* gradle: code format

* use default NDK version=21.0.6113669

* use Timber instead of Log

* convert BreadActivity to FragmentActivity in order to handle back pressed from fragments

* handle back button on BuyFragment

* upgrade firebase libs version to latest

* Handle AUD, GBP, HKD, IDR, RUB and SGD currencies

* upgrade gradle/gradle build tool to respectively 6.5 and 4.1.0

* handle document upload for KYC verification

* update support/policy/social links

* update README: replace iOS by Android

* use zendesk support email address

* make sure the selected fiat option is always visible

* setup kotlin

* cleanup + use timber

* use androidx fragment

* update libs

* FragmentSend: IDE convertion to kotlin

* FragmentSend: tweak kotlin conversion

* FragmentSend: UD integration

* BRButton: disable touch effect when disabled

* DynamicDonationFragment: convert to android

* DynamicDonationFragment: use lambda

* UDResolution: only resolve LTC domains

* FragmentSend: translation

* translate “Lookup”

* rename tryBitcoinURL to tryLitecoinURL

* add…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android related only 🚀 release Related to a production release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants