Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature-based minting restriction #7

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Hadrienlc
Copy link

@Hadrienlc Hadrienlc commented Nov 19, 2021

close #3
based on #4

@Hadrienlc Hadrienlc self-assigned this Nov 19, 2021
@Hadrienlc Hadrienlc marked this pull request as ready for review November 19, 2021 04:15
@NicolasMahe
Copy link
Member

Need to check with Rarible dev:

  • Is it ok to add the signature to the data.signature payload. No breaking change from the smart contract view.
  • Do they prefer to add a new function that accept a another parameter "operator signature"? Even it is requires a lot more changes in the rest of the code base to implement it.

@NicolasMahe NicolasMahe marked this pull request as draft November 29, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mint restriction: Signature-based minting
2 participants