Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from starlite import * broken if testing extra not installed #181

Closed
peterschutt opened this issue Jun 27, 2022 · 0 comments · Fixed by #183
Closed

from starlite import * broken if testing extra not installed #181

peterschutt opened this issue Jun 27, 2022 · 0 comments · Fixed by #183

Comments

@peterschutt
Copy link
Contributor

peterschutt commented Jun 27, 2022

This is only an issue on main, not in any release.

When I want to try a library out, I'll install it into a fresh env, run python repl and do from lib import * and have a play around. If just doing that raised an error it would freak me out a little about the lib.

Possible solution:

  • remove .testing imports from starlite.__all__
  • add deprecation warning for top-level .testing imports
  • remove if TYPE_CHECKING too? May as well if we are doing the above, I think?

Refs: #174 #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant