-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: typo in channels docs create_route_handlers
-> create_ws_route_handlers
#3596
Comments
Is this issue still open? I'm new to the project and would to take this on. |
Yes, feel free 🙂 |
Great! Also. since I do not have access to a linux machine, (I'm using a mac), am I limited to only doc contributions? |
I would say, if anything Windows is what that could be iffy, as long as tests run it should mostly be ok |
@l-armstrong You can use your mac to contribute anything or GitHub codespaces if you would like (https://codespaces.new/litestar-org/litestar?quickstart=1). No blockers there :) |
@JacobCoffee great, thank you! |
I'm running into an error whenever I try to commit my changes.
On the documentation to contribute it says:
I'm currently running Python 3.12 in Visual Studio Code which meet the requirements. In the .pre-commit-config.yaml file, it states
Does this mean I have to specifically run 3.8? My assumption is that somewhere in the codebase, its expecting to find "3.8" locally, but I'm new to the project so this could be wrong. |
I believe Py38 just needs to be available in $PATH for it to run. |
I created a PR for this issue. |
Reported by
Coffee in Discord: #general
Description
Btw, there is a small typo (https://docs.litestar.dev/latest/usage/channels.html#id9) "create_route_handlers"
MCVE
N/A
Logs
N/A
Litestar Version
Main
Note
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard
The text was updated successfully, but these errors were encountered: