-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livebook Desktop for Mac app crashes on startup when hostname contains whitespace #1850
Comments
Thank you for the report @cgrothaus. Honestly, I am a bit puzzled to why Apple allows a space in the hostname, as that is not allowed in the specification: https://datatracker.ietf.org/doc/html/rfc952 The error itself is coming from Erlang, and we could try to request them to allow such names, but I am also skeptical about changing Erlang to support a hostname that goes against the RFC. |
Thanks for the clarification @josevalim. You're right, Apple is doing something fishy here. I should have come to that conclusion myself. Perhaps checking the launcher script (I assume there is one that kicks of the beam) for this illegal situation and displaying a warning is an option? Or do you think this is too much special case handling for a rare bug? |
We will see how we can improve the desktop app in this case to make sure it is logged. If it helps anyone, I can reproduce the issue with |
On my macOS I got the following issue, I thought it would be localhost by default but it picked up something from configuration which I don't know about and is not
|
@josevalim yeah I was able to reproduce the issue and I got the error dialog and the following was logged:
so yeah, not super helpful. Any pointers how we could go about improving the experience? |
@wojtekmach could we check something either in the .sh.eex file or in the Swift script for empty spaces in host names? |
Yeah, a .sh.eex check is the easiest way to go about this. Thanks! |
Environment
Erlang/OTP 25 [erts-13.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]
Elixir 1.14.3 (compiled with Erlang/OTP 25)
~/Library/Logs/Livebook.log
:Current behavior
My company macbook was set up in a way that the hostname is something like
Christoph Grothauss Mac
, i.e. the hostname contains whitespace. This leads to a crash when starting up livebook, stating that the short node name cannot be set.Temporary Workaround
Configure the hostname to not contain whitespace.
Expected behavior
The livebook macOS application can cope with hostnames that contain whitespaces and starts up successfully.
The text was updated successfully, but these errors were encountered: