Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing docker image #553

Closed
sobolevn opened this issue Sep 18, 2021 · 3 comments
Closed

Testing docker image #553

sobolevn opened this issue Sep 18, 2021 · 3 comments

Comments

@sobolevn
Copy link
Contributor

sobolevn commented Sep 18, 2021

Right now docker images are not tested.
It might be a problem.

I suggest to add a special action that runs separately and check that docker image works correctly.
We can run only a very simple checks, not all test suite. For example:

  1. Port is available, response is correct
  2. Mix.install works

Refs #543
Refs #552

@jonatanklosko
Copy link
Member

Since this is a reproducible image, the only moving part is Livebook itself, and that we do test. The difference from the mix setup is that we package it into a release, but with that we could at most do some http-request level testing and I don't think this would cover much. Given that Livebook is a dev tool, it seems perfectly effective to rely on the users reporting any discrepancies (which, as said, are not very likely assuming the initial image works fine). @josevalim wdyt?

If you have any particular concern/scenario in mind or I missed the point let me know :)

@josevalim
Copy link
Contributor

I agree with @jonatanklosko. The image is going to be mostly static, so I think the odds of messing it up is pretty low to the point I am comfortable with not having image tests.

@sobolevn
Copy link
Contributor Author

Ok! I am going to close this. We can always reopen the task and add tests if needed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants