Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tx cost check when calculating ticket face value for O #2049

Closed
yondonfu opened this issue Oct 1, 2021 · 0 comments · Fixed by #2071
Closed

Remove tx cost check when calculating ticket face value for O #2049

yondonfu opened this issue Oct 1, 2021 · 0 comments · Fixed by #2071
Assignees

Comments

@yondonfu
Copy link
Member

yondonfu commented Oct 1, 2021

Right now, when an O calculates the face value for a ticket, if the face value is less than the estimated tx cost, the O returns an insufficient sender reserve error. The idea behind this behavior was that if the estimated tx cost can't be covered by the face value then the O can just return an error early. But, the problem with this behavior is that the estimated tx cost could change in between the time that the ticket face value is calculated and advertised and the time that a winning ticket is to be redeemed. It is possible that the face value can't cover the estimated tx cost right now, but it could cover it later on when gas prices have come down. I think it would be preferable behavior for the O to return the ticket face value even if it can't cover the estimated tx cost right now because it could cover the estimated tx cost later. Additionally, the O is configured not to redeem the ticket if the face value at the time of redemption can't cover the tx cost so there is still protection from unprofitable redemptions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant