Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve contextual logging #2102

Closed
iameli opened this issue Nov 12, 2021 · 0 comments · Fixed by #2121
Closed

improve contextual logging #2102

iameli opened this issue Nov 12, 2021 · 0 comments · Fixed by #2121
Assignees

Comments

@iameli
Copy link
Contributor

iameli commented Nov 12, 2021

It's very difficult these days to use go-livepeer logs to ascertain what's going wrong with a particular broadcast, as most logs.

I propose the following for our logs:

  1. Any log that occurs within the context of a stream should have a manifestId listed. Ditto with sessionId for logging that occurs within the context.
  2. Make sure all logging uses consistent formatting, e.g. manifestId=ABC123 everywhere.

I'm not sure the best way to make this happen. Maybe we'd start using a context object in more places, so it can get passed down? It'd be good if it could make it all the way down to the LPMS code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants