Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config variables not working properlly #2613

Closed
stronk-dev opened this issue Oct 5, 2022 · 4 comments
Closed

Config variables not working properlly #2613

stronk-dev opened this issue Oct 5, 2022 · 4 comments
Assignees
Labels
area: orchestrator QoL need: investigation need to investigate what is happening before proceeding type: bug Something isn't working

Comments

@stronk-dev
Copy link
Contributor

Config parameters often break, where even though they are defined in the launch script they do not get parsed correctly and use their default value instead. Changing the order of the parameters or using a = instead of a often fixes the issue, which causes confusion for new O's coming in:

There have been plenty of other instances where over the past few months, maybe we can add some more verbosity over what config variables it has read or what values it is using?

@github-actions github-actions bot added the status: triage this issue has not been evaluated yet label Oct 5, 2022
@ArcAster ArcAster added need: investigation need to investigate what is happening before proceeding area: orchestrator QoL and removed status: triage this issue has not been evaluated yet labels Oct 5, 2022
@leszko leszko added the type: bug Something isn't working label Oct 5, 2022
@cyberj0g
Copy link
Contributor

cyberj0g commented Oct 7, 2022

I think, it's a good idea to echo customized (because full list is too large) config values after livepeer start. WDYT?

@cyberj0g cyberj0g self-assigned this Oct 7, 2022
@stronk-dev
Copy link
Contributor Author

Yeah that sounds like a good first step, maybe we can also echo the full launch command on boot? So far I've only seen these kind of issues pop up with command line flags and not with with environment variables or config files

@thomshutt
Copy link
Contributor

thomshutt commented Oct 7, 2022

Not sure how easy this would be given we're using the golang flags package, but maybe printing all non-default flags could be a good subset?

@thomshutt
Copy link
Contributor

Just realised that's what you meant by customized @cyberj0g 🤦 In that case, sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: orchestrator QoL need: investigation need to investigate what is happening before proceeding type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants