Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y/N Confirmation when sending a transaction via the CLI #2212

Closed
hthillman opened this issue Jan 25, 2022 · 5 comments
Closed

Y/N Confirmation when sending a transaction via the CLI #2212

hthillman opened this issue Jan 25, 2022 · 5 comments
Labels
area: cli area: orchestrator QoL good first issue status: community working on it in progress type: feature New feature or request

Comments

@hthillman
Copy link
Contributor

Split out from #2106

Whenever the Livepeer CLI will submit a transaction, we should require confirmation from the user. If an action will submit multiple transactions, the user should be warned in advance
@github-actions github-actions bot added the status: triage this issue has not been evaluated yet label Jan 25, 2022
@hthillman hthillman mentioned this issue Jan 25, 2022
Closed
@hthillman hthillman added good first issue help wanted and removed status: triage this issue has not been evaluated yet labels Jan 25, 2022
@noisersup
Copy link
Contributor

Can I work on it?

noisersup added a commit to noisersup/go-livepeer that referenced this issue Jan 26, 2022
@noisersup
Y/N Confirmation when sending a transaction via the CLI (livepeer#2212)
e439152
@noisersup noisersup mentioned this issue Jan 26, 2022
Merged
5 tasks
@hthillman
Copy link
Contributor Author

yes, thanks for getting involved! we'll get you some feedback on that PR as soon as possible

@hthillman
Copy link
Contributor Author

looks like this has been merged, thanks @noisersup! closing 👍

@chrishobcroft
Copy link
Contributor

Hey, just checking in on this - I just used livepeer_cli 0.5.27 to operate Livepeer on Arbitrum One Rinkeby. Several transactions were sent without any Y/N Confirmation.

@leszko
Copy link
Contributor

leszko commented Feb 4, 2022

I see the PR #2215 was only about sending the transfer and for every transaction. So we may consider reopening this GH Issue. @hthillman wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: cli area: orchestrator QoL good first issue status: community working on it in progress type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chrishobcroft @leszko @hthillman @noisersup