From 8af0bdd4d3ad8a8a3bf74de83c58fd180595e8b7 Mon Sep 17 00:00:00 2001 From: Thom Shutt Date: Wed, 30 Mar 2022 16:12:37 +0100 Subject: [PATCH 1/2] doc: Fix syntax errors in example JSON * Remove trailing commas * FPS has to be an integer * Profile has to be a string --- doc/transcodingoptions.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/transcodingoptions.md b/doc/transcodingoptions.md index 0287e37a10..d6cd4e6bb5 100644 --- a/doc/transcodingoptions.md +++ b/doc/transcodingoptions.md @@ -89,21 +89,21 @@ An example of a full JSON configuration: "bitrate": 5000000, "fps": 30000, "fpsDen": 1001, - "profile": H264High, - "gop": "2", + "profile": "H264High", + "gop": "2" },{ "name": "webrtc-720p", "width": 1280, "height": 720, "bitrate": 1500000, - "profile": H264ConstrainedHigh, + "profile": "H264ConstrainedHigh" },{ "name":"highlight-reel", "width":160, "height":120, "bitrate":100000, - "fps": "0.1", - "gop":"intra", + "fps": 1, + "gop":"intra" } ] ``` From 06046176ef6d5c197d9b21113d4e8ba5542e11e6 Mon Sep 17 00:00:00 2001 From: Thom Shutt Date: Wed, 30 Mar 2022 16:15:17 +0100 Subject: [PATCH 2/2] Update pending Changelog --- CHANGELOG_PENDING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index 31ebb8c77b..452a6c26b7 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -23,6 +23,7 @@ #### General - \#2299 Split devtool Orchestrator run scripts into versions with/without external transcoder and prevent Transcoder/Broadcaster run scripts from using same CLI port (@thomshutt) +- \#2346 Fix syntax errors in example JSON #### Broadcaster - \#2296 Increase orchestrator discovery timeout from `500ms` to `1` (@leszko)