From 68e2b695eae06b42261ecdc145c1f1ece57cd14c Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sun, 22 Sep 2024 08:02:32 -0500 Subject: [PATCH] [NvlinkWrapper] Fix `-pluing` not consuming its argument Summary: Sometimes `clang` will pass `-plugin` when doing LTO, which should be correctly consumed by the nvlink wrapper. Right now it was leaving the `plugin.so` argument as a regular input, which would cause it to error on the `.so` input. --- clang/tools/clang-nvlink-wrapper/NVLinkOpts.td | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td b/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td index ef1a7542e495021..eeb9d1a6228240c 100644 --- a/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td +++ b/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td @@ -39,7 +39,7 @@ def library_S : Separate<["--", "-"], "library">, Flags<[HelpHidden]>, def library_EQ : Joined<["--", "-"], "library=">, Flags<[HelpHidden]>, Alias; -def plugin : Joined<["--", "-"], "plugin">, +def plugin : JoinedOrSeparate<["--", "-"], "plugin">, Flags<[HelpHidden, WrapperOnlyOption]>; def arch : Separate<["--", "-"], "arch">,