[IPSCCP] Don't crash on ptrtoint

llvm · Oct 24, 2023 · eb67b34 · eb67b34
1 parent 4a074f3
commit eb67b34
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp
@@ -3079,7 +3079,6 @@ void llvm::hoistAllInstructionsInto(BasicBlock *DomBlock, Instruction *InsertPt,
 
 DIExpression *llvm::getExpressionForConstant(DIBuilder &DIB, const Constant &C,
                                              Type &Ty) {
-
   // Create integer constant expression.
   auto createIntegerExpression = [&DIB](const Constant &CV) -> DIExpression * {
     const APInt &API = cast<ConstantInt>(&CV)->getValue();
@@ -3089,7 +3088,7 @@ DIExpression *llvm::getExpressionForConstant(DIBuilder &DIB, const Constant &C,
                       : nullptr;
   };
 
-  if (Ty.isIntegerTy())
+  if (isa<ConstantInt>(C))
     return createIntegerExpression(C);
 
   if (Ty.isFloatTy() || Ty.isDoubleTy()) {

diff --git a/llvm/unittests/Transforms/Utils/LocalTest.cpp b/llvm/unittests/Transforms/Utils/LocalTest.cpp
@@ -1223,6 +1223,11 @@ TEST(Local, ExpressionForConstant) {
   EXPECT_NE(Expr, nullptr);
   EXPECT_EQ(Expr->getElement(1), 0x7FFFFFFFFFFFFFFFU);
 
+  GlobalVariable *String =
+      IRBuilder<>(Context).CreateGlobalString("hello", "hello", 0, &M);
+  Expr = createExpression(ConstantExpr::getPtrToInt(String, Int32Ty), Int32Ty);
+  EXPECT_EQ(Expr, nullptr);
+
   // Float.
   Type *FloatTy = Type::getFloatTy(Context);
   Expr = createExpression(ConstantFP::get(FloatTy, 5.55), FloatTy);