Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MachO LLD - Crash when both ObjC category merge + relative method lists are enabled #105611

Closed
alx32 opened this issue Aug 22, 2024 · 5 comments · Fixed by #104081
Closed

MachO LLD - Crash when both ObjC category merge + relative method lists are enabled #105611

alx32 opened this issue Aug 22, 2024 · 5 comments · Fixed by #104081
Assignees
@alx32
Labels
lld:MachO release:backport
Milestone
LLVM 19.X Release

Comments

@alx32
Copy link
Contributor

alx32 commented Aug 22, 2024

A crash happens when both ObjC category merge + relative method lists are enabled.

Repro can be tested by adding -objc_relative_method_lists to lld invocations in lld/test/MachO/objc-category-merging-minimal.s
@github-actions github-actions bot added the lld label Aug 22, 2024
@alx32 alx32 self-assigned this Aug 22, 2024
@alx32 alx32 linked a pull request Aug 22, 2024 that will close this issue
[lld-macho] Fix crash: ObjC category merge + relative method lists #104081
Merged
@alx32
Copy link
Contributor Author

alx32 commented Aug 22, 2024

Fixed by PR #104081

@alx32 alx32 closed this as completed Aug 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2024

@llvm/issue-subscribers-lld-macho

Author: None (alx32)

A crash happens when both ObjC category merge + relative method lists are enabled.

Repro can be tested by adding -objc_relative_method_lists to lld invocations in lld/test/MachO/objc-category-merging-minimal.s

@alx32 alx32 added this to the LLVM 19.X Release milestone Aug 22, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Aug 22, 2024
@alx32
Copy link
Contributor Author

alx32 commented Aug 22, 2024 •
edited
Loading

/cherry-pick 0df9189

To not have this scenario crash in the 19.0 branch

@alx32 alx32 modified the milestone: LLVM 19.X Release Aug 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2024

Failed to cherry-pick: 0df9189

https://github.com/llvm/llvm-project/actions/runs/10502185807

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@alx32 alx32 modified the milestone: LLVM 19.X Release Aug 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2024

/pull-request #105615

@nikic nikic moved this from Needs Triage to Done in LLVM Release Status Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alx32 alx32

Labels
lld:MachO release:backport
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 19.X Release
Development

Successfully merging a pull request may close this issue.

[lld-macho] Fix crash: ObjC category merge + relative method lists alx32/llvm-project
3 participants
@EugeneZelenko @llvmbot @alx32