Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::atomic<long double>::compare_exchange_weak does not update expected on failure #47978

Closed
llvmbot opened this issue Dec 30, 2020 · 2 comments
Closed

std::atomic<long double>::compare_exchange_weak does not update expected on failure #47978

llvmbot opened this issue Dec 30, 2020 · 2 comments
Labels
bugzilla Issues migrated from bugzilla c++20 clang:codegen duplicate Resolved as duplicate libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@llvmbot
Copy link
Member

llvmbot commented Dec 30, 2020 •
edited by Endilll
Loading

Bugzilla Link 48634
Version 11.0
OS Linux
Attachments Program reproducing the bug.
Reporter LLVM Bugzilla Contributor
CC @zygoloid

Extended Description

This program does not behave as intended:

#include <atomic>
#include <iostream>
int main() {
  std::atomic<long double> x;
  x.store(1.0);
  long double tmp = 2.0;
  bool worked = x.compare_exchange_weak(tmp, 3.0);
  std::cout << "worked " << worked << " set tmp to " << tmp << std::endl;

  std::atomic<double> x2;
  x2.store(1.0);
  double tmp2 = 2.0;
  worked = x2.compare_exchange_weak(tmp2, 3.0);
  std::cout << "worked " << worked << " set tmp to " << tmp2 << std::endl;

  return 0;
}

I compile with

  clang++-12 -std=c++17 atomiclongdoublecompareexchangeweak.cpp \
             -o atomiclongdoublecompareexchangeweak -Wall -O0 -g -latomic

The output is:

worked 0 set tmp to 2
worked 0 set tmp to 1

The expected output is

worked 0 set tmp to 1
worked 0 set tmp to 1

My version of clang++-12 is:

% clang++-12 -v
Ubuntu clang version 12.0.0-++20201229052625+b76014a4f15a-1~exp1~20201229163322.268
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/10
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/10
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/10
Candidate multilib: .;@m64
Selected multilib: .;@m64

The same problem occurs with clang++11 and other optimization levels.

The problem is that

  std::atomic<long double>::compare_exchange_weak(long double& expected,
                                                  long double desired)

does not update expected as specified when the expected value is not
found.

Here are the libraries my program is linked against:

% ldd ./atomiclongdoublecompareexchangeweak
	linux-vdso.so.1 (0x00007fffe5b79000)
	libatomic.so.1 => /lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f61dcb69000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f61dc988000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f61dc839000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f61dc81e000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f61dc62c000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f61dc609000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f61dcb9c000)

The problem seems to be that the atomic headers lead to the fact that in
the end the compiler intrinsic

  __atomic_compare_exchange

is called for the 16 byte case. Unfortunately, I cannot easily find the
source code for this. In any case this function seems to misbehave
for the 16 byte case. I have traced the assembler code and this shows
the wrong behaviour.
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
@ldionne ldionne mentioned this issue Oct 2, 2023
Merged
@huixie90 huixie90 changed the title std::atomic<long double>::compare_exchange_weak does not update expected on failure std::atomic<long double>::compare_exchange_weak does not update expected on failure Oct 9, 2023
@Endilll Endilll added the clang:to-be-triaged Should not be used for new issues label Jul 18, 2024
@frederick-vs-ja
Copy link
Contributor

Closing as a duplicate of:

See also #64829.

@frederick-vs-ja frederick-vs-ja added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. clang:codegen duplicate Resolved as duplicate and removed clang:to-be-triaged Should not be used for new issues labels Jan 2, 2025
@llvmbot
Copy link
Member Author

llvmbot commented Jan 2, 2025

@llvm/issue-subscribers-clang-codegen

Author: None (llvmbot)

| | | | --- | --- | | Bugzilla Link | [48634](https://llvm.org/bz48634) | | Version | 11.0 | | OS | Linux | | Attachments | [Program reproducing the bug.](https://user-images.githubusercontent.com/60944935/143761585-ccbc075a-2193-43fd-90a8-039eb63b5067.gz) | | Reporter | LLVM Bugzilla Contributor | | CC | @zygoloid |

Extended Description

This program does not behave as intended:

#include &lt;atomic&gt;
#include &lt;iostream&gt;
int main() {
  std::atomic&lt;long double&gt; x;
  x.store(1.0);
  long double tmp = 2.0;
  bool worked = x.compare_exchange_weak(tmp, 3.0);
  std::cout &lt;&lt; "worked " &lt;&lt; worked &lt;&lt; " set tmp to " &lt;&lt; tmp &lt;&lt; std::endl;

  std::atomic&lt;double&gt; x2;
  x2.store(1.0);
  double tmp2 = 2.0;
  worked = x2.compare_exchange_weak(tmp2, 3.0);
  std::cout &lt;&lt; "worked " &lt;&lt; worked &lt;&lt; " set tmp to " &lt;&lt; tmp2 &lt;&lt; std::endl;

  return 0;
}

I compile with

  clang++-12 -std=c++17 atomiclongdoublecompareexchangeweak.cpp \
             -o atomiclongdoublecompareexchangeweak -Wall -O0 -g -latomic

The output is:

worked 0 set tmp to 2
worked 0 set tmp to 1

The expected output is

worked 0 set tmp to 1
worked 0 set tmp to 1

My version of clang++-12 is:

% clang++-12 -v
Ubuntu clang version 12.0.0-++20201229052625+b76014a4f15a-1~exp1~20201229163322.268
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/10
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/10
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/8
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/10
Candidate multilib: .;@<!-- -->m64
Selected multilib: .;@<!-- -->m64

The same problem occurs with clang++11 and other optimization levels.

The problem is that

  std::atomic&lt;long double&gt;::compare_exchange_weak(long double&amp; expected,
                                                  long double desired)

does not update expected as specified when the expected value is not
found.

Here are the libraries my program is linked against:

% ldd ./atomiclongdoublecompareexchangeweak
	linux-vdso.so.1 (0x00007fffe5b79000)
	libatomic.so.1 =&gt; /lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f61dcb69000)
	libstdc++.so.6 =&gt; /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f61dc988000)
	libm.so.6 =&gt; /lib/x86_64-linux-gnu/libm.so.6 (0x00007f61dc839000)
	libgcc_s.so.1 =&gt; /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f61dc81e000)
	libc.so.6 =&gt; /lib/x86_64-linux-gnu/libc.so.6 (0x00007f61dc62c000)
	libpthread.so.0 =&gt; /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f61dc609000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f61dcb9c000)

The problem seems to be that the atomic headers lead to the fact that in
the end the compiler intrinsic

  __atomic_compare_exchange

is called for the 16 byte case. Unfortunately, I cannot easily find the
source code for this. In any case this function seems to misbehave
for the 16 byte case. I have traced the assembler code and this shows
the wrong behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla c++20 clang:codegen duplicate Resolved as duplicate libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
C++ 20 in Clang
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Endilll @frederick-vs-ja @llvmbot