Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for running tests in Windows Containers #49331

Closed
mstorsjo opened this issue Apr 16, 2021 · 2 comments
Closed

Backport fixes for running tests in Windows Containers #49331

mstorsjo opened this issue Apr 16, 2021 · 2 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@mstorsjo
Copy link
Member

Bugzilla Link 49987
Resolution FIXED
Resolved on May 03, 2021 17:08
Version trunk
OS All
Blocks #48661
CC @tstellar
Fixed by commit(s) 9de63b2 a885567 eae7f3e 072c90a

Extended Description

I'd appreciate if the following two commits can be backported to the 12.x branch:

commit 9de63b2
Author: Martin Storsjö [email protected]
Date: Thu Mar 18 14:08:10 2021 +0200

[lit] Pass the USERPROFILE variable through on Windows

commit a885567
Author: Martin Storsjö [email protected]
Date: Wed Mar 24 23:58:54 2021 +0200

[LLD] Fix probing a MSYS based 'tar' in a Windows Container

These two allow running tests with MSYS based tools within Windows Containers (which are used in the current CI setup, which afaik also runs tests for the release branches). This allows exposing bash within PATH in the image used for the containers (the same image is used for testing of the main branch too).

The commits apply cleanly and I can do the actual cherrypicking, if it's deemed ok.

@mstorsjo
Copy link
Member Author

Backported as eae7f3e and 072c90a, thanks!

@tstellar
Copy link
Collaborator

tstellar commented May 4, 2021

Merged: 072c90a

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants