diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index 371f6598e6b2b35..187820717b6fd5c 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -7999,6 +7999,8 @@ static bool tryUnmergingGEPsAcrossIndirectBr(GetElementPtrInst *GEPI, return false; if (UGEPI->getOperand(0) != GEPIOp) return false; + if (UGEPI->getSourceElementType() != GEPI->getSourceElementType()) + return false; if (GEPIIdx->getType() != cast(UGEPI->getOperand(1))->getType()) return false; diff --git a/llvm/test/CodeGen/X86/indirect-br-gep-unmerge.ll b/llvm/test/CodeGen/X86/indirect-br-gep-unmerge.ll new file mode 100644 index 000000000000000..6b953e3004256ee --- /dev/null +++ b/llvm/test/CodeGen/X86/indirect-br-gep-unmerge.ll @@ -0,0 +1,51 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 3 +; RUN: opt -S -codegenprepare %s -o - | FileCheck %s + +target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +%struct.Blub = type { i8, i8, ptr } + +@indirectBrPtr = external hidden global ptr + +define ptr @testFunc(ptr readonly %array, i1 %skip) { +; CHECK-LABEL: define ptr @testFunc( +; CHECK-SAME: ptr readonly [[ARRAY:%.*]], i1 [[SKIP:%.*]]) { +; CHECK-NEXT: entry: +; CHECK-NEXT: br i1 [[SKIP]], label [[LOOPHEADER:%.*]], label [[ENDBLOCK_CLONE:%.*]] +; CHECK: loopHeader: +; CHECK-NEXT: [[CURRENTARRAYELEMENT:%.*]] = phi ptr [ [[ARRAY]], [[ENTRY:%.*]] ], [ [[NEXTARRAYELEMENT:%.*]], [[LOOPFOOTER:%.*]] ] +; CHECK-NEXT: [[ELEMENTVALUEPTR:%.*]] = getelementptr inbounds i8, ptr [[CURRENTARRAYELEMENT]], i64 1 +; CHECK-NEXT: [[ELEMENTVALUE:%.*]] = load i8, ptr [[ELEMENTVALUEPTR]], align 1 +; CHECK-NEXT: indirectbr ptr @indirectBrPtr, [label [[LOOPFOOTER]], label %endBlock] +; CHECK: loopFooter: +; CHECK-NEXT: [[ISGOODVALUE:%.*]] = icmp eq i8 [[ELEMENTVALUE]], 0 +; CHECK-NEXT: [[NEXTARRAYELEMENT]] = getelementptr inbounds [[STRUCT_BLUB:%.*]], ptr [[CURRENTARRAYELEMENT]], i64 1 +; CHECK-NEXT: br i1 [[ISGOODVALUE]], label [[LOOPHEADER]], label [[ENDBLOCK_CLONE]] +; CHECK: endBlock: +; CHECK-NEXT: br label [[DOTSPLIT:%.*]] +; CHECK: .split: +; CHECK-NEXT: [[MERGE:%.*]] = phi ptr [ [[ELEMENTVALUEPTR]], [[ENDBLOCK:%.*]] ], [ [[RETVAL_CLONE:%.*]], [[ENDBLOCK_CLONE]] ] +; CHECK-NEXT: ret ptr [[MERGE]] +; CHECK: endBlock.clone: +; CHECK-NEXT: [[RETVAL_CLONE]] = phi ptr [ [[ARRAY]], [[ENTRY]] ], [ [[ELEMENTVALUEPTR]], [[LOOPFOOTER]] ] +; CHECK-NEXT: br label [[DOTSPLIT]] +; +entry: + br i1 %skip, label %loopHeader, label %endBlock + +loopHeader: + %currentArrayElement = phi ptr [ %array, %entry ], [ %nextArrayElement, %loopFooter ] + %elementValuePtr = getelementptr inbounds i8, ptr %currentArrayElement, i64 1 + %elementValue = load i8, ptr %elementValuePtr, align 1 + indirectbr ptr @indirectBrPtr, [label %loopFooter, label %endBlock] + +loopFooter: + %isGoodValue = icmp eq i8 %elementValue, 0 + %nextArrayElement = getelementptr inbounds %struct.Blub, ptr %currentArrayElement, i64 1 + br i1 %isGoodValue, label %loopHeader, label %endBlock + +endBlock: + %retVal = phi ptr [ %array, %entry ], [ %elementValuePtr, %loopFooter ], [ %elementValuePtr, %loopHeader ] + ret ptr %retVal +}