Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: fix model select not auto update and sort issue #5330

Merged
merged 1 commit into from
Jan 8, 2025
Merged

🐛 fix: fix model select not auto update and sort issue #5330

merged 1 commit into from
Jan 8, 2025
+51 −16

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Jan 8, 2025 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • 修正模型选择后没有正常刷新的问题
  • 修正模型排序问题
  • 修正 ModelSelect provider 图标没有正确显示的 bug

📝 补充信息 | Additional Information

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:52am
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:52am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 8, 2025
@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.73%. Comparing base (bde6d64) to head (6459e67).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/store/aiInfra/slices/aiProvider/action.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5330   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         591      591           
  Lines       46027    46035    +8     
  Branches     2833     2834    +1     
=======================================
+ Hits        42221    42229    +8     
  Misses       3806     3806
Flag Coverage Δ
app 91.73% <83.33%> (+<0.01%) ⬆️
server 98.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit dc76d6f into main Jan 8, 2025
12 checks passed
@arvinxx arvinxx deleted the fix/model-sort branch January 8, 2025 02:22
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
🔖 chore(release): v1.44.1 [skip ci]
19c426b 
### [Version&nbsp;1.44.1](v1.44.0...v1.44.1)
<sup>Released on **2025-01-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix model select not auto update and sort issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix model select not auto update and sort issue, closes [#5330](#5330) ([dc76d6f](dc76d6f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.44.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arvinxx arvinxx mentioned this pull request Jan 8, 2025
Open
4 tasks
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 8, 2025
@semantic-release-bot
🔖 chore(release): v1.86.1 [skip ci]
7d44712 
### [Version&nbsp;1.86.1](v1.86.0...v1.86.1)
<sup>Released on **2025-01-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix model select not auto update and sort issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix model select not auto update and sort issue, closes [lobehub#5330](https://github.com/bentwnghk/lobe-chat/issues/5330) ([dc76d6f](dc76d6f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
AirboZH pushed a commit to yuanze-dev/lobe-chat that referenced this pull request Jan 9, 2025
@arvinxx @AirboZH
🐛 fix: fix model select not auto update and sort issue (lobehub#5330)
526ffc4
AirboZH pushed a commit to yuanze-dev/lobe-chat that referenced this pull request Jan 9, 2025
@semantic-release-bot @AirboZH
🔖 chore(release): v1.44.1 [skip ci]
989e38e 
### [Version&nbsp;1.44.1](lobehub/lobe-chat@v1.44.0...v1.44.1)
<sup>Released on **2025-01-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix model select not auto update and sort issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix model select not auto update and sort issue, closes [lobehub#5330](lobehub#5330) ([dc76d6f](lobehub@dc76d6f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 Bug Something isn't working | 缺陷 released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot