Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid rescuing all exception from inline script #60

Open
kares opened this issue Jan 6, 2021 · 0 comments
Open

avoid rescuing all exception from inline script #60

kares opened this issue Jan 6, 2021 · 0 comments

Comments

@kares
Copy link
Contributor

kares commented Jan 6, 2021

When an unexpected exception occurs with an code => ... inline script, the plugin catches everything due rescue Exception.

This isn't ideal as it will also catch any serious java.lang.Error throwables such as OutOfMemoryError and recover from them.

The issue only concerns inline script, path => ... script reach a default rescue => e form and thus won't recover from errors.


History shows there might not have been a clear intent to rescue "everything", rescue Exception dates back to the (1.0.0) initial support for recovering from Ruby exceptions. Which than got refactored (probably to keep compatibility) with the addition of file based scripting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants