Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrays of zero length do not (un)pack in some situations #52

Closed
lojack5 opened this issue Oct 3, 2024 · 0 comments · Fixed by #55
Closed

Arrays of zero length do not (un)pack in some situations #52

lojack5 opened this issue Oct 3, 2024 · 0 comments · Fixed by #55
Assignees
@lojack5
Labels
bug Something isn't working
Milestone
3.1.0 Release

Comments

@lojack5
Copy link
Owner

lojack5 commented Oct 3, 2024

Specifically, dynamically sized arrays of simple types throw an exception when packing/unpacking a zero-length array. This comes down to computing the serializer for the array on the fly not accounting for 0 * item_serializer correctly.
@lojack5 lojack5 added the bug Something isn't working label Oct 3, 2024
@lojack5 lojack5 self-assigned this Oct 3, 2024
@lojack5 lojack5 linked a pull request Oct 3, 2024 that will close this issue
Allow for 0-length dynamic arrays of simple types #55
Merged
@lojack5 lojack5 mentioned this issue Oct 3, 2024
Merged
@lojack5 lojack5 added this to the 3.1.0 Release milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lojack5 lojack5

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0 Release
Development

Successfully merging a pull request may close this issue.

Allow for 0-length dynamic arrays of simple types lojack5/structured
1 participant
@lojack5