Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate SDKs for Looker 25.0 #1558

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: generate SDKs for Looker 25.0 #1558

merged 1 commit into from
Jan 13, 2025

Conversation

drstrangelooker
Copy link
Collaborator

@drstrangelooker drstrangelooker commented Jan 13, 2025 •
edited
Loading

The content-validation endpoint and associated method has a breaking change for at least some languages, notably TypeScript. The passed parameters have changed.

Release-As: 25.0.0

@drstrangelooker drstrangelooker requested a review from a team as a code owner January 13, 2025 20:59
@github-actions GitHub Actions
Copy link
Contributor

Go Tests

  6 files    6 suites   2m 26s ⏱️
 50 tests  50 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 498b16a.

@github-actions GitHub Actions
Copy link
Contributor

Python Tests

 10 files  ±0   10 suites  ±0   1m 16s ⏱️ -1s
144 tests ±0  139 ✅ ±0   5 💤 ±0  0 ❌ ±0 
792 runs  ±0  770 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 498b16a. ± Comparison against base commit 8294c19.

@github-actions GitHub Actions
Copy link
Contributor

Typescript Tests

  2 files   56 suites   58s ⏱️
208 tests 207 ✅ 1 💤 0 ❌
444 runs  442 ✅ 2 💤 0 ❌

Results for commit 498b16a.

jkaster
jkaster requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least document that the content_validation function for the TypeScript SDK has a breaking change because of the newly created Request object for the endpoint

packages/sdk/src/4.0/methodsInterface.ts
* @param options one-time API call overrides
*
*/
content_validation(
fields?: string,
request: IRequestContentValidation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking SDK change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who should go back to helltool and fix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry didn't see the top level comment.

How do you recommend we document?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it to the commit message so that it goes into the changelog.

@jkaster jkaster self-requested a review January 13, 2025 21:34
@drstrangelooker drstrangelooker merged commit 56502e5 into main Jan 13, 2025
41 checks passed
@drstrangelooker drstrangelooker deleted the sdk_25_0 branch January 13, 2025 21:36
Merged
drstrangelooker added a commit that referenced this pull request Jan 13, 2025
@looker-open-source-automation-bot @drstrangelooker
chore: release main (#1545)
bca935b 
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.71</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.37 to 0.1.38
    * @looker/extension-utils bumped from 0.1.47 to 0.1.48
    * @looker/run-it bumped from 0.9.70 to 0.9.71
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk-codegen bumped from 21.9.6 to 21.9.7
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.27 to 21.5.28
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/code-editor: 0.1.38</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk-codegen bumped from 21.9.6 to 21.9.7
</details>

<details><summary>@looker/extension-api-explorer: 22.21.28</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.70 to 0.9.71
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/extension-sdk-react bumped from 24.20.0 to 25.0.0
    * @looker/extension-utils bumped from 0.1.47 to 0.1.48
    * @looker/run-it bumped from 0.9.70 to 0.9.71
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk-codegen bumped from 21.9.6 to 21.9.7
</details>

<details><summary>@looker/extension-playground: 1.0.28</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/extension-sdk-react bumped from 24.20.0 to 25.0.0
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/extension-tile-playground: 1.1.15</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/extension-sdk-react bumped from 24.20.0 to 25.0.0
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/extension-utils: 0.1.48</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.37 to 0.1.38
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/extension-sdk-react bumped from 24.20.0 to 25.0.0
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/hackathon: 22.21.30</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.37 to 0.1.38
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/extension-sdk-react bumped from 24.20.0 to 25.0.0
    * @looker/extension-utils bumped from 0.1.47 to 0.1.48
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/wholly-artifact bumped from 0.1.28 to 0.1.29
</details>

<details><summary>@looker/run-it: 0.9.71</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from 0.1.37 to 0.1.38
    * @looker/extension-utils bumped from 0.1.47 to 0.1.48
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk-codegen bumped from 21.9.6 to 21.9.7
    * @looker/sdk-codegen-utils bumped from 21.0.17 to 21.0.18
</details>

<details><summary>@looker/sdk-codegen: 21.9.7</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk-codegen-utils bumped from 21.0.17 to 21.0.18
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.28</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk-codegen bumped from 21.9.6 to 21.9.7
    * @looker/sdk-codegen-utils bumped from 21.0.17 to 21.0.18
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/sdk-codegen-utils: 21.0.18</summary>

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/wholly-artifact: 0.1.29</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
  * devDependencies
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>@looker/wholly-sheet: 0.5.67</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
  * devDependencies
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>sdk-codegen-all: 25.0.0</summary>

##
[25.0.0](sdk-codegen-all-v24.20.1...sdk-codegen-all-v25.0.0)
(2025-01-13)


### Features

* generate SDKs for Looker 25.0
([#1558](#1558))
([56502e5](56502e5))


### Bug Fixes

* Improve ok() helper function
([#1542](#1542))
([7b15f90](7b15f90))
</details>

<details><summary>looker_sdk: 25.0.0</summary>

##
[25.0.0](looker_sdk-v24.20.0...looker_sdk-v25.0.0)
(2025-01-13)


### Features

* generate SDKs for Looker 25.0
([#1558](#1558))
([56502e5](56502e5))
</details>

<details><summary>embed-components: 25.0.0</summary>

##
[25.0.0](embed-components-v24.20.0...embed-components-v25.0.0)
(2025-01-13)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 24.20.0 to 25.0.0
    * @looker/sdk bumped from 24.20.0 to 25.0.0
  * devDependencies
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>embed-services: 25.0.0</summary>

##
[25.0.0](embed-services-v24.20.0...embed-services-v25.0.0)
(2025-01-13)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
  * devDependencies
    * @looker/sdk-node bumped from 24.20.0 to 25.0.0
</details>

<details><summary>extension-sdk: 25.0.0</summary>

##
[25.0.0](extension-sdk-v24.20.0...extension-sdk-v25.0.0)
(2025-01-13)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

<details><summary>extension-sdk-react: 25.0.0</summary>

##
[25.0.0](extension-sdk-react-v24.20.0...extension-sdk-react-v25.0.0)
(2025-01-13)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.20.0 to 25.0.0
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

<details><summary>sdk: 25.0.0</summary>

##
[25.0.0](sdk-v24.20.0...sdk-v25.0.0)
(2025-01-13)


### Features

* generate SDKs for Looker 25.0
([#1558](#1558))
([56502e5](56502e5))
</details>

<details><summary>sdk-node: 25.0.0</summary>

##
[25.0.0](sdk-node-v24.20.0...sdk-node-v25.0.0)
(2025-01-13)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.20.0 to 25.0.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Mike DeAngelo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drstrangelooker @jkaster