Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect pre-commit executable on more platforms / with more installation methods #128

Closed
lorenzwalthert opened this issue Mar 29, 2020 · 0 comments

Comments

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Mar 29, 2020

Any installation method that puts the executable on $PATH will be detected anyways. We can further look in more places so people don't have to link manually. The hierarchy should be:

  • detect on PATH.
  • if not there, detect with conda (via reticulate).
  • if not there, detect os specific via pip and brew.

We aim to detect installation methods that are officially supported.

Status quo

platform conda (env reticulate) pip (user) brew
macOS ✅ via reticulate ✅ ~/Library/Python/:py-version/bin ✅ /usr/local/bin
linux ✅ via reticulate ✅ ~/.local/bin ❌ not available
windows ✅ via reticulate ✅ ~\AppData\Roaming\Python\Scripts ❌ not available

Legend

❌: not implemented
✅: implemented
⚠️: WIP

Detecting on a platform should be tested on CI/CD similar to existing test the ones introduced for macOS and pip in Linux in #121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant