Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldRun's docs aren't clear, or a bug, or a FR? #231

Open
edalzell opened this issue Mar 31, 2023 · 2 comments · May be fixed by lorisleiva/laravel-actions-docs#60
Open

shouldRun's docs aren't clear, or a bug, or a FR? #231

edalzell opened this issue Mar 31, 2023 · 2 comments · May be fixed by lorisleiva/laravel-actions-docs#60
Labels
support A question for how to use Actions

Comments

@edalzell
Copy link

I was working on testing my actions and used the shouldRun method and it wasn't working.

Turns out I need to add ->once() in order for a test to actually run.

I'm not sure if this is a bug, a feature request or a documentation thing, please advise and I'll update the appropriate thing in a PR.

At a minimum I believe the docs should be updated to show a working example (as that's what I copied). Alternatively, we could update shouldRun etc to call once? In PHPUnit land you can use expects to call once automatically.

@Ashraam
Copy link

Ashraam commented Nov 23, 2023

Can't agree more !

@Wulfheart Wulfheart added the support A question for how to use Actions label Oct 17, 2024
@Wulfheart
Copy link
Collaborator

Needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support A question for how to use Actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants